Fix python farsite flat test#137
Conversation
Bugs fixed for farsite_flat.py, input files also provided
filippi
left a comment
There was a problem hiding this comment.
Thanks, it is intended to be very experimental at this point, but removes local files dependencies
filippi
left a comment
There was a problem hiding this comment.
Hi, these files are not explicitly open source, I believe it is just Zeroes so OK
but for larger cases, add a download link , I won't add it to the main repo
|
[heart] Fernando Veiga López reacted to your message:
…________________________________
From: Jean-Baptiste Filippi ***@***.***>
Sent: Wednesday, October 29, 2025 8:01:05 AM
To: forefireAPI/forefire ***@***.***>
Cc: Fernando Veiga López ***@***.***>; Author ***@***.***>
Subject: Re: [forefireAPI/forefire] Fix python farsite flat test (PR #137)
@filippi approved this pull request.
Thanks, it is intended to be very experimental at this point, but removes local files dependencies
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/forefireAPI/forefire/pull/137*pullrequestreview-3392085382__;Iw!!D9dNQwwGXtA!R55dak-2GwfW6WgkaYpPQy4WfEpHjWQNA29QEIpom2_oyTkXSOFOPmR12fVA7blFRHwUtTcQ_ihb4kvHpca2ps0TWH7g2sU$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/BFECAPPT4H4USLUUXYBZOXT32BX4DAVCNFSM6AAAAACKQV5LHCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGOJSGA4DKMZYGI__;!!D9dNQwwGXtA!R55dak-2GwfW6WgkaYpPQy4WfEpHjWQNA29QEIpom2_oyTkXSOFOPmR12fVA7blFRHwUtTcQ_ihb4kvHpca2ps0TFSTlRlM$>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Hi, unfortunately we hit the LFS usage, so not possible to add the files...is it possible to make a download link from somewhere else ? |
filippi
left a comment
There was a problem hiding this comment.
Hi, readme was already in the test/ directory, you can modify it. thanks a lot
also, could you please make pull requests on the dev branch ? not main ?
regards
No description provided.