Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
269 changes: 146 additions & 123 deletions package-lock.json

Large diffs are not rendered by default.

20 changes: 10 additions & 10 deletions packages/code-analyzer-eslint-engine/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@salesforce/code-analyzer-eslint-engine",
"description": "Plugin package that adds 'eslint' as an engine into Salesforce Code Analyzer",
"version": "0.37.1",
"version": "0.38.0-SNAPSHOT",
"author": "The Salesforce Code Analyzer Team",
"license": "BSD-3-Clause",
"homepage": "https://developer.salesforce.com/docs/platform/salesforce-code-analyzer/overview",
Expand All @@ -13,33 +13,33 @@
"main": "dist/index.js",
"types": "dist/index.d.ts",
"dependencies": {
"@eslint/js": "^9.39.1",
"@eslint/js": "^9.39.2",
"@lwc/eslint-plugin-lwc": "^3.3.0",
"@lwc/eslint-plugin-lwc-platform": "^6.3.0",
"@salesforce-ux/eslint-plugin-slds": "^1.0.7",
"@salesforce/code-analyzer-engine-api": "0.32.0",
"@salesforce/code-analyzer-eslint8-engine": "0.9.0",
"@salesforce/eslint-config-lwc": "^4.1.1",
"@salesforce/eslint-config-lwc": "^4.1.2",
"@salesforce/eslint-plugin-lightning": "^2.0.0",
"@types/node": "^20.0.0",
"@typescript-eslint/eslint-plugin": "^8.47.0",
"@typescript-eslint/parser": "^8.47.0",
"eslint": "^9.39.1",
"@typescript-eslint/eslint-plugin": "^8.50.0",
"@typescript-eslint/parser": "^8.50.0",
"eslint": "^9.39.2",
"eslint-plugin-import": "^2.32.0",
"eslint-plugin-jest": "^29.2.0",
"eslint-plugin-jest": "^29.5.0",
"globals": "^16.5.0",
"semver": "^7.7.3",
"typescript": "^5.9.3",
"typescript-eslint": "^8.47.0"
"typescript-eslint": "^8.50.0"
},
"devDependencies": {
"@types/jest": "^30.0.0",
"@types/semver": "^7.7.1",
"@types/unzipper": "^0.10.11",
"cross-env": "^10.1.0",
"jest": "^30.2.0",
"rimraf": "^6.0.1",
"ts-jest": "^29.4.5",
"rimraf": "^6.1.2",
"ts-jest": "^29.4.6",
"unzipper": "^0.12.3"
},
"engines": {
Expand Down
4 changes: 4 additions & 0 deletions packages/code-analyzer-eslint-engine/src/rule-mappings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1476,6 +1476,10 @@ export const RULE_MAPPINGS: Record<string, {severity: SeverityLevel, tags: strin
severity: SeverityLevel.High,
tags: [/* NOT RECOMMENDED */ COMMON_TAGS.CATEGORIES.ERROR_PRONE, COMMON_TAGS.LANGUAGES.TYPESCRIPT]
},
"@typescript-eslint/no-useless-default-assignment": {
severity: SeverityLevel.Moderate,
tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.CATEGORIES.BEST_PRACTICES, COMMON_TAGS.LANGUAGES.TYPESCRIPT]
},
"@typescript-eslint/no-useless-empty-export": {
severity: SeverityLevel.Moderate,
tags: [/* NOT RECOMMENDED */ COMMON_TAGS.CATEGORIES.BEST_PRACTICES, COMMON_TAGS.LANGUAGES.TYPESCRIPT]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,7 @@
"description": "Enforce assertion to be made in a test body",
"name": "jest/expect-expect",
"resourceUrls": [
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.2.1/docs/rules/expect-expect.md"
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.5.0/docs/rules/expect-expect.md"
],
"severityLevel": 5,
"tags": [
Expand All @@ -685,7 +685,7 @@
"description": "Disallow alias methods",
"name": "jest/no-alias-methods",
"resourceUrls": [
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.2.1/docs/rules/no-alias-methods.md"
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.5.0/docs/rules/no-alias-methods.md"
],
"severityLevel": 3,
"tags": [
Expand All @@ -699,7 +699,7 @@
"description": "Disallow commented out tests",
"name": "jest/no-commented-out-tests",
"resourceUrls": [
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.2.1/docs/rules/no-commented-out-tests.md"
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.5.0/docs/rules/no-commented-out-tests.md"
],
"severityLevel": 5,
"tags": [
Expand All @@ -713,7 +713,7 @@
"description": "Disallow calling `expect` conditionally",
"name": "jest/no-conditional-expect",
"resourceUrls": [
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.2.1/docs/rules/no-conditional-expect.md"
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.5.0/docs/rules/no-conditional-expect.md"
],
"severityLevel": 2,
"tags": [
Expand All @@ -727,7 +727,7 @@
"description": "Disallow disabled tests",
"name": "jest/no-disabled-tests",
"resourceUrls": [
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.2.1/docs/rules/no-disabled-tests.md"
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.5.0/docs/rules/no-disabled-tests.md"
],
"severityLevel": 5,
"tags": [
Expand All @@ -741,7 +741,7 @@
"description": "Disallow using a callback in asynchronous tests and hooks",
"name": "jest/no-done-callback",
"resourceUrls": [
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.2.1/docs/rules/no-done-callback.md"
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.5.0/docs/rules/no-done-callback.md"
],
"severityLevel": 3,
"tags": [
Expand All @@ -755,7 +755,7 @@
"description": "Disallow using `exports` in files containing tests",
"name": "jest/no-export",
"resourceUrls": [
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.2.1/docs/rules/no-export.md"
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.5.0/docs/rules/no-export.md"
],
"severityLevel": 3,
"tags": [
Expand All @@ -769,7 +769,7 @@
"description": "Disallow focused tests",
"name": "jest/no-focused-tests",
"resourceUrls": [
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.2.1/docs/rules/no-focused-tests.md"
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.5.0/docs/rules/no-focused-tests.md"
],
"severityLevel": 3,
"tags": [
Expand All @@ -783,7 +783,7 @@
"description": "Disallow identical titles",
"name": "jest/no-identical-title",
"resourceUrls": [
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.2.1/docs/rules/no-identical-title.md"
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.5.0/docs/rules/no-identical-title.md"
],
"severityLevel": 3,
"tags": [
Expand All @@ -797,7 +797,7 @@
"description": "Disallow string interpolation inside snapshots",
"name": "jest/no-interpolation-in-snapshots",
"resourceUrls": [
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.2.1/docs/rules/no-interpolation-in-snapshots.md"
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.5.0/docs/rules/no-interpolation-in-snapshots.md"
],
"severityLevel": 2,
"tags": [
Expand All @@ -811,7 +811,7 @@
"description": "Disallow Jasmine globals",
"name": "jest/no-jasmine-globals",
"resourceUrls": [
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.2.1/docs/rules/no-jasmine-globals.md"
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.5.0/docs/rules/no-jasmine-globals.md"
],
"severityLevel": 3,
"tags": [
Expand All @@ -825,7 +825,7 @@
"description": "Disallow manually importing from `__mocks__`",
"name": "jest/no-mocks-import",
"resourceUrls": [
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.2.1/docs/rules/no-mocks-import.md"
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.5.0/docs/rules/no-mocks-import.md"
],
"severityLevel": 2,
"tags": [
Expand All @@ -839,7 +839,7 @@
"description": "Disallow using `expect` outside of `it` or `test` blocks",
"name": "jest/no-standalone-expect",
"resourceUrls": [
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.2.1/docs/rules/no-standalone-expect.md"
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.5.0/docs/rules/no-standalone-expect.md"
],
"severityLevel": 3,
"tags": [
Expand All @@ -853,7 +853,7 @@
"description": "Require using `.only` and `.skip` over `f` and `x`",
"name": "jest/no-test-prefixes",
"resourceUrls": [
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.2.1/docs/rules/no-test-prefixes.md"
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.5.0/docs/rules/no-test-prefixes.md"
],
"severityLevel": 3,
"tags": [
Expand All @@ -867,7 +867,7 @@
"description": "Enforce valid `describe()` callback",
"name": "jest/valid-describe-callback",
"resourceUrls": [
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.2.1/docs/rules/valid-describe-callback.md"
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.5.0/docs/rules/valid-describe-callback.md"
],
"severityLevel": 2,
"tags": [
Expand All @@ -881,7 +881,7 @@
"description": "Enforce valid `expect()` usage",
"name": "jest/valid-expect",
"resourceUrls": [
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.2.1/docs/rules/valid-expect.md"
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.5.0/docs/rules/valid-expect.md"
],
"severityLevel": 3,
"tags": [
Expand All @@ -895,7 +895,7 @@
"description": "Require promises that have expectations in their chain to be valid",
"name": "jest/valid-expect-in-promise",
"resourceUrls": [
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.2.1/docs/rules/valid-expect-in-promise.md"
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.5.0/docs/rules/valid-expect-in-promise.md"
],
"severityLevel": 3,
"tags": [
Expand All @@ -909,7 +909,7 @@
"description": "Enforce valid titles",
"name": "jest/valid-title",
"resourceUrls": [
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.2.1/docs/rules/valid-title.md"
"https://github.com/jest-community/eslint-plugin-jest/blob/v29.5.0/docs/rules/valid-title.md"
],
"severityLevel": 3,
"tags": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1083,6 +1083,19 @@
"TypeScript"
]
},
{
"description": "Disallow default values that will never be used",
"name": "@typescript-eslint/no-useless-default-assignment",
"resourceUrls": [
"https://typescript-eslint.io/rules/no-useless-default-assignment"
],
"severityLevel": 3,
"tags": [
"Recommended",
"BestPractices",
"TypeScript"
]
},
{
"description": "Disallow empty exports that don't change anything in a module file",
"name": "@typescript-eslint/no-useless-empty-export",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
[versions]
hamcrest = "3.0"
junit-jupiter = "5.13.4"
pmd = "7.18.0" # !!! IMPORTANT !!! KEEP THIS IN SYNC WITH PMD_VERSION INSIDE OF: src/constants.ts
pmd = "7.19.0" # !!! IMPORTANT !!! KEEP THIS IN SYNC WITH PMD_VERSION INSIDE OF: src/constants.ts

# For the following: Keep in sync with whatever pmd-core pulls in. Basically, we don't want duplicates in our java-lib folder.
# To see pmd-core's dependencies, go to https://mvnrepository.com/artifact/net.sourceforge.pmd/pmd-core
Expand Down
12 changes: 6 additions & 6 deletions packages/code-analyzer-pmd-engine/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@salesforce/code-analyzer-pmd-engine",
"description": "Plugin package that adds 'pmd' and 'cpd' as engines into Salesforce Code Analyzer",
"version": "0.33.0",
"version": "0.34.0-SNAPSHOT",
"author": "The Salesforce Code Analyzer Team",
"license": "BSD-3-Clause",
"homepage": "https://developer.salesforce.com/docs/platform/salesforce-code-analyzer/overview",
Expand All @@ -16,17 +16,17 @@
"@salesforce/code-analyzer-engine-api": "0.32.0",
"@types/node": "^20.0.0",
"@types/semver": "^7.7.1",
"semver": "^7.7.2"
"semver": "^7.7.3"
},
"devDependencies": {
"@eslint/js": "^9.39.1",
"@eslint/js": "^9.39.2",
"@types/jest": "^30.0.0",
"eslint": "^9.39.1",
"eslint": "^9.39.2",
"jest": "^30.2.0",
"rimraf": "^6.1.2",
"ts-jest": "^29.4.5",
"ts-jest": "^29.4.6",
"typescript": "^5.9.3",
"typescript-eslint": "^8.47.0"
"typescript-eslint": "^8.50.0"
},
"engines": {
"node": ">=20.0.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/code-analyzer-pmd-engine/src/constants.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// !!! IMPORTANT !!! KEEP THIS IN SYNC WITH gradle/libs.versions.toml
export const PMD_VERSION: string = '7.18.0';
export const PMD_VERSION: string = '7.19.0';

export const PMD_ENGINE_NAME: string = "pmd";
export const CPD_ENGINE_NAME: string = "cpd";
Expand Down
14 changes: 11 additions & 3 deletions packages/code-analyzer-pmd-engine/src/pmd-rule-mappings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ export const RULE_MAPPINGS: Record<string, {severity: SeverityLevel, tags: strin
severity: SeverityLevel.Low,
tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.CATEGORIES.PERFORMANCE, COMMON_TAGS.LANGUAGES.APEX]
},
"AvoidFutureAnnotation": {
severity: SeverityLevel.Low,
tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.CATEGORIES.BEST_PRACTICES, COMMON_TAGS.LANGUAGES.APEX]
},
"AvoidDeeplyNestedIfStmts": {
severity: SeverityLevel.Moderate,
tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.CATEGORIES.DESIGN, COMMON_TAGS.LANGUAGES.APEX]
Expand Down Expand Up @@ -170,7 +174,7 @@ export const RULE_MAPPINGS: Record<string, {severity: SeverityLevel, tags: strin
},
"ExcessiveClassLength": {
severity: SeverityLevel.Moderate,
tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.CATEGORIES.DESIGN, COMMON_TAGS.LANGUAGES.APEX]
tags: [/* NOT RECOMMENDED */ COMMON_TAGS.CATEGORIES.DESIGN, COMMON_TAGS.LANGUAGES.APEX]
},
"ExcessiveParameterList": {
severity: SeverityLevel.Moderate,
Expand Down Expand Up @@ -222,11 +226,15 @@ export const RULE_MAPPINGS: Record<string, {severity: SeverityLevel, tags: strin
},
"NcssConstructorCount": {
severity: SeverityLevel.Low,
tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.CATEGORIES.DESIGN, COMMON_TAGS.LANGUAGES.APEX]
tags: [/* NOT RECOMMENDED */ COMMON_TAGS.CATEGORIES.DESIGN, COMMON_TAGS.LANGUAGES.APEX]
},
"NcssCount": {
severity: SeverityLevel.Moderate,
tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.LANGUAGES.APEX, COMMON_TAGS.CUSTOM]
},
"NcssMethodCount": {
severity: SeverityLevel.Low,
tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.CATEGORIES.DESIGN, COMMON_TAGS.LANGUAGES.APEX]
tags: [/* NOT RECOMMENDED */ COMMON_TAGS.CATEGORIES.DESIGN, COMMON_TAGS.LANGUAGES.APEX]
},
"NcssTypeCount": {
severity: SeverityLevel.Low,
Expand Down
Loading