W-22917328: Rename beacon_child_consumer_{key,secret} to auto_installed_app_org_consumer_{key,secret}#4057
Open
wmathurin wants to merge 2 commits into
Open
Conversation
|
||||||||||||||||||
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4057 +/- ##
==========================================
- Coverage 71.00% 66.65% -4.36%
==========================================
Files 246 246
Lines 21477 21481 +4
==========================================
- Hits 15250 14318 -932
- Misses 6227 7163 +936
🚀 New features to boost your workflow:
|
|
||||||||||||||||
|
||||||||||||||
bbirman
approved these changes
Jun 10, 2026
…y,secret} to auto_installed_app_org_consumer_{key,secret}
Updates only the string values parsed from the token endpoint response.
All code symbol names (constants, properties, methods) are unchanged.
wmathurin
force-pushed
the
rename-beacon-child-consumer-keys
branch
from
2b8431a to
75872eb
Compare
3 tasks
…eld absent
Checks auto_installed_app_org_consumer_{key,secret} first; falls back to
the old beacon_child_consumer_{key,secret} name for servers that have not
yet rolled out version 264.
Contributor
Author
|
I decided to only change the value of the fields we look for in the response and keep beacon in our code and tests. The changes were getting large and would make cherry picking harder. Further more AutoInstalledApp is a mouthful compared to Beacon. |
wmathurin
commented
Jun 10, 2026
| if (params[kSFOAuthTokenFormat]) { | ||
| self.tokenFormat = params[kSFOAuthTokenFormat]; | ||
| } | ||
| // TODO: Remove kSFOAuthLegacyBeaconChildConsumer* fallback once server version 264 has rolled out everywhere. |
Contributor
Author
There was a problem hiding this comment.
That way we can go against older instances and it should still work.
Clang Static Analysis Issues
Generated by 🚫 Danger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the token endpoint wire-format keys and adds a legacy fallback for servers that haven't yet rolled out version 264.
When parsing the token response, the SDK now:
auto_installed_app_org_consumer_{key,secret}(new field name)beacon_child_consumer_{key,secret}if the new field is absentA
TODOcomment marks both fallback constants and the fallback logic for removal once server version 264 has rolled out everywhere.All code symbol names (
kSFOAuthBeaconChildConsumerKey,beaconChildConsumerKeyproperty, etc.) are unchanged.Files changed
SFSDKOAuthConstants.h— new constant values + legacy fallback constants addedSFOAuthCredentials.m— parsing updated with new-then-old fallbackSFSDKOAuthTokenEndpointResponseTests.m— test key strings updatedSFOAuthCredentialsTests.m— test key strings updatedTest plan
SalesforceSDKCoreunit test suite passes (iPhone 16 / iOS 18.6)Related