Repository navigation
fix(ci): read the caller's perf config from the calling commit - #7
Merged
Merged
Conversation
…he commit under test A Routr release tag (the commit under test) can predate perf/, so the start job failed with 'cannot read: no such file'. --commit still reports the commit under test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first DigitalOcean run (fonoster/routr Benchmarks run 41754588068) failed before creating anything:
perfkit: perf/perfkit.smoke.yaml: cannot read: no such file.run.yamlchecked outinputs.commit, the commit under test, which was the v2.31.7 release tag. That tag predates Routr'sperf/.The start job now checks out
github.sha, the commit that called the workflow.--commitstill writes the commit under test into report.json. Also bumps the version to 0.1.1 and updates docs/github-workflow.md.No droplets were created by the failed run; the DigitalOcean API lists 0 droplets tagged
perfkit.🤖 Generated with Claude Code