Repository navigation
feat: project.favicon, a 10 s step check, and the history copy fix - #20
Merged
Merged
Conversation
Pages are drawn by the current app, so an older run is redrawn by a newer perfkit.
SIPp writes its statistics every 10 s, so a step like 15s mixes the counters of two steps. perfkit.yaml validation now rejects it at load.rate.every.
perfkit.yaml takes an optional project.favicon (.svg, relative to the file). The run reads it when it starts and inlines it as project.faviconSvg in report.json and live.json. The shells, the run page and the live page link it as a URL-encoded data:image/svg+xml icon; without one, the pages are unchanged.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small changes.
1.
project.favicon(feat). perfkit.yaml takes an optionalproject.favicon: a path relative to perfkit.yaml,.svgonly, the same asproject.logo.perfkit validatechecks that the file exists. The run reads it when it starts and inlines it asproject.faviconSvgin report.json and live.json (perfkit/live/v1reuses the report's project schema). Every page head links it as<link rel="icon" type="image/svg+xml" href="data:image/svg+xml,...">(URL-encoded SVG): the shells (index.htmland eachruns/<id>/index.html, so the tab has its icon before the app draws), the run page and the live page. The shells use the favicon of the report being rendered. Without a favicon, no link is written and the pages stay byte for byte the same. The JSON Schema files are regenerated (npm run schemas).2. Step length check (fix). SIPp writes its counters every 10 s, so a capacity step whose
load.rate.everyis not a multiple of 10 s mixes two steps. Validation now rejects it:benchmarks[0].load.rate.every: expected a multiple of 10 s (SIPp reports every 10 s); got 15s. The duration-to-seconds helper moved out ofcheckWarmupShorterThanStepintosrc/schemas/durationSeconds.tsso both checks use it.3. History copy (fix). "Every run keeps its own page and report.json. Open one to see it exactly as it was." is now "Every run keeps its own page and report.json.", because the current app redraws every page.
Docs:
docs/perfkit-yaml.md(field table and example),docs/report-v1.md(project.faviconSvg),docs/report-page.md, and the README's Capacity section.For callers pinning a version: perfkit.yaml gains an optional field and rejects steps that aren't a multiple of 10 s (the examples use
60s). report.json and live.json gain an optionalproject.faviconSvg. The workflow inputs are unchanged.Verify:
npm test(643 passing),npm run typecheck,npm run lint.🤖 Generated with Claude Code