Repository navigation
fix(orchestrate): demux Docker logs in a loop, not by recursion - #16
Merged
Merged
Conversation
demuxLogs recursed once per log frame. Reading a 6-hour soak's sampler file from the UUT over SSH produced enough frames to overflow the call stack, and the agent failed with "Maximum call stack size exceeded" at the end of the run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routr's 6-hour soak (run 41898433488) failed at the end with
the agent failed: Maximum call stack size exceeded.demuxLogsrecursed once per Docker log frame.cat sampler-uut.jsonlover SSH for a 6.5-hour run produced enough small frames to overflow the stack. The 1-hour soak's file was small enough to get by.The fix is a plain loop. The new test demuxes 200,000 one-line frames: it fails on main with
RangeError: Maximum call stack size exceededand passes now. 445 tests pass. Version 0.1.10.Not in this PR: when the agent fails, the workflow's cleanup deletes the droplets before any raw results are downloaded, so the 6 hours of data were lost.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WSt25Wd7udAq3aj47MKn5J