Repository navigation
feat: accept { name, tagSuffix } image entries in perfkit.yaml (0.1.6) - #12
Merged
Merged
Conversation
An images entry may now be an object { name, tagSuffix }; its tag is
--target-version followed by tagSuffix (like 2.32.0-go-experimental).
Plain string entries behave as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for callers
imagesentry can be{ name, tagSuffix }besides a plain image name. Its tag is--target-versionfollowed bytagSuffix:{ name: fonoster/routr-edgeport, tagSuffix: -go-experimental }with--target-version 2.32.0runsfonoster/routr-edgeport:2.32.0-go-experimental.tagSuffixmust match^[A-Za-z0-9._-]+$;namemust carry no tag or digest. String entries behave exactly as before.PERFKIT_IMAGE_<KEY>= key upper-cased, every non[A-Z0-9]character turned into_. A keyedgeportGogivesPERFKIT_IMAGE_EDGEPORTGO(now documented).run.imagesholdsname:tag@sha256:…, and the existing regex already accepts suffixed tags (test added).Digest resolution,
--dry-runoutput and--localall go through the same resolver.schemas/perfkit-v1.schema.jsonregenerated. Docs:docs/perfkit-yaml.md,docs/project-setup.md. Version 0.1.6.Tests
Schema accept/reject, resolve with suffix, dry-run line, compose env names, report regex. typecheck, lint and
npm test(439 passing).🤖 Generated with Claude Code
https://claude.ai/code/session_01WSt25Wd7udAq3aj47MKn5J