STCLI-273 Translate compile on Windows - cross-env globbing. #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zburke
approved these changes
Nov 17, 2025
Member
zburke
left a comment
zburke
left a comment
There was a problem hiding this comment.
LGTM but
- We should figure out if fast-glob is really even necessary here or if we could as easily grab stuff with straight up node APIs, or with the formatjs APIs.
- Please file a STCLI story and stick it in the PR title before you merge so the jira<->github magic linker can find it in the commit log and keep them sync'ed. Having the Jira paperwork in order is helpful when managing official releases.
JohnC-80
changed the title
|
JohnC-80
added a commit
that referenced
this pull request
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows 😝path.join(txPath, '*.json')results infast-globreportedly needsEDIT: Just switched to using
fs.globSyncand canned the dep.