Repository navigation
feat(packages): show managed and custom subjects in package record - #723
Merged
Merged
Conversation
Map HoldingsIQ subjectAssociations to a new read-only subjects array on package data attributes. Managed subjects are always included; custom subjects are included only when explicitly assigned. Refs: MODKBEKBJ-853
Add a managed subject to the package by-id RM API stub and expected responses, and to the RAML package example. Refs: MODKBEKBJ-853
Use the by-id subjectAssociations field set (subjectHierarchy, explicitAssignment) in the package by-id stub and add a custom non-explicit subject that must be excluded. Add subjects to the package list RAML example. Refs: MODKBEKBJ-853
HoldingsIQ package list responses do not include explicitAssignment, so filtering there dropped every custom subject. Return all subjects in package lists and keep the custom placeholder filter for the package record. Refs: MODKBEKBJ-853
Remove subjects from package list responses and keep them on the package record only. Refs: MODKBEKBJ-853
Refs: MODKBEKBJ-853
|
psmagin
approved these changes
Oct 15, 2026
Aliaksandr-Fedasiuk
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
The package detail record in eHoldings has to show the package's managed and custom subjects. HoldingsIQ already returns them as
subjectAssociations, but mod-kb-ebsco-java didn't pass them through to the UI.Approach
packageSubject.jsonschema with these fields:id,nameandisCustom.subjectsarray topackageDataAttributes.json.PackageConverter, used byGET/PUT /eholdings/packages/{packageId}andPOST /eholdings/packages) mapssubjectAssociationstosubjectswith filtering:isCustomisnull.explicitAssignmentistrue. Custom hierarchy placeholders without an explicit assignment are dropped.subjectAssociationsis missing,subjectsisnull.PackageCollectionItemConverter, e.g.GET /eholdings/packages, provider packages) don't includesubjects. HoldingsIQ list responses don't provideexplicitAssignment, so custom placeholders can't be told apart there.Changes Checklist
attributes.subjectsarray (id,name,isCustom), which is additive. The new schema isramls/types/packages/packageSubject.json. The package by-id RAML example includessubjects.eholdings5.0.folio-holdingsiq-client6.0.0-SNAPSHOT(FHIQC-60).PackageConverterTestcovers the record filtering and field mapping (managed vs. custom,isCustom=null, missingsubjectAssociations).subjectsisn't returned.EholdingsPackagesIntegrationTest,EholdingsProvidersImplIntegrationTestandEholdingsResourcesImplIntegrationTestpass.Related Issues