MODDICORE-432: Vendor details are empty with code that contains brackets during order creation #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VRohach
requested review from
Aliaksandr-Fedasiuk,
JavokhirAbdullayev,
RomanChernetskyi and
RuslanLavrov
| return true; | ||
| } else if (ruleName.equalsIgnoreCase(VENDOR_ID) && retrieveNameWithoutBrackets(mappingParameter).equalsIgnoreCase(retrieveNameWithoutBrackets(value))) { | ||
| } else if (ruleName.equalsIgnoreCase(VENDOR_ID) && | ||
| (retrieveCodeWithoutBrackets(mappingParameter).equalsIgnoreCase(retrieveNameWithoutBrackets(value)) || |
Contributor
There was a problem hiding this comment.
Hi @VRohach! could you tell me please, shouldn't we compare code with code here? instead of code with name?
Contributor
Author
There was a problem hiding this comment.
Hello @JavokhirAbdullayev! There will be comparing code for vendor from organizations and value from mapping profile. I don't know how to rename "retrieveNameWithoutBrackets"-method because it was already using for retrieving name for vendor from organizations.
Contributor
Author
There was a problem hiding this comment.
@JavokhirAbdullayev Btw I renamed it to "retrieveNameOrValueWithoutBrackets".
Aliaksandr-Fedasiuk
approved these changes
Jan 8, 2025
|
JavokhirAbdullayev
approved these changes
Jan 8, 2025
RomanChernetskyi
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The main goal is to fix mechanism for matching vendor code with brackets.
Approach
Additional condition added.
Learning
JIRA: https://folio-org.atlassian.net/browse/MODDICORE-432