Repository navigation
Conversation
An independent review showed that two requests sent with Promise.all interleave only about half the time. The nine older tests of a race — payments, refunds, cancellations — call functions side by side instead, and a probe found those overlap every time: both readings before either write, in twenty-five rounds of twenty-five. They now run through atTheSameMoment, which gives each call a database that notes when it is used and fails unless every call had read before any wrote. A change that put a wait in front of a reading would have turned such a race into a sequence and left its test passing; now it fails. The helper has tests of its own, for the case it must refuse. With everything that stops its second write taken away, each of the nine was red eight times in eight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
The review of the inquiry cart showed that two requests sent with
Promise.allinterleave only about half the time. This looks at the nine older tests of a race — a payment reported twice at once, two refunds, a payment against a cancellation — for the same weakness.They do not have it. They call functions side by side rather than send requests, and such calls overlap every time: in twenty-five rounds of two payments at once, both readings reached the database before either write, in one and the same order.
So none had to be rewritten. What changes is that this is now seen on every run instead of taken on trust: the nine run through
atTheSameMoment, which hands each call a database that notes when it is used and fails unless every call had read before any wrote. A change that put a wait in front of a reading would have turned such a race into a sequence and left its test passing.How it was verified
One thing that showed: a payment's write is stopped by several keys at once, so removing the shared status condition turns no race between two payments red. The races between two different changes of an order have no key in common, and do go red without it.