Repository navigation
chore: move to mallok 0.1.0-rc.11, the release with plugin API 2 - #5
Merged
Merged
Conversation
Pinned exactly: rc.11 is under npm's next tag only, and latest is still rc.10. The upgrade changed no code. Its notes ask every site for a second rate-limit binding, RATE_LIMITER_RELAXED, which mallok upgrade does not add; it takes the strict tier's namespace plus one.
Mallok's inquiry plugin now reads its labels from the theme's language pack, key by key, and keeps its own English and Chinese as the fallback. The six keys go into the three packs the plugin has no words for, and stay out of the default pack: a pack falls back to the default one, so English keys there would replace the plugin's own text in every language this theme has no pack for.
Mallok's tagline was one string for every language, so a theme option stood in front of it. It is a map of language to text now, and Mallok describes each language's home page with it. The tagline option goes; site.json carries the four taglines where Mallok keeps them. The home_description option stays, for a site that wants more than a tagline under its name in a search result. An option was removed, so the theme is 0.5.0.
A template could not ask where a kind's list page is, so the link from the home page's finder to the whole catalogue was a theme option, given again for each language, and a breadcrumb went from the home page straight to the page. Mallok now gives every template site.kinds, with an entry exactly when the list page exists. The option goes, and one breadcrumb partial serves every layout: home, the list of the kind, a product's collection, the page.
What each extension point of the design became in the release, what happened to the five stand-ins the sample theme needed, and the one that stays: a plugin switch or a settings change can still leave cached pages as they were.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
Mallok published plugin API 2 — the extension points the rest of the shop was waiting for — in
0.1.0-rc.10and0.1.0-rc.11. This moves Nundar onto0.1.0-rc.11and removes the stand-ins it had for four Mallok behaviours that release answers. It builds nothing on the new API; that is the pull request stacked on this one.mallokis pinned exactly. rc.11 is under npm'snexttag only, andlatestis still rc.10, so a range or a tag would not select it.The five commits
chore: move to mallok 0.1.0-rc.11…npx mallok upgrade. It changed no code.wrangler.jsoncgains the second rate-limit binding the upgrade notes ask every site for, whichmallok upgradedoes not addfeat: label the inquiry form in German, French and Spanishrefactor: take the tagline from the site's settings, per languagehome_descriptionstays, as an option in its own rightrefactor: link to a kind's list page through site.kindsdocs: record what the move … changed and foundThe theme is
0.5.0: two options were removed.What stays as it was, on purpose
Switching a plugin or changing a setting can still leave cached pages as they were, and the admin's "Clear cached pages" can report success without clearing anything — Mallok's own finding on a deployed site, fixed on a branch and not released. So the plugins are still switched on before the first publish, the README still says so, and the tests still delete the cached home page by hand after changing settings.
How it was verified
npm run lint,npm run typecheck,npm run buildnpm run test:projectnpm run test:shopnpm run smoke,npm run smoke:shop,npm run preview -- --checkNot verified