Feature: migrate editable table to mui#995
Open
santipalenque wants to merge 4 commits into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…ix bulk-save data corruption - Use actions.edit.onClick/actions.delete.onClick (passing the full row) instead of a separate handleDeleteRow prop and a hardcoded history.push, matching the convention used by every other list page in this codebase. - Drop the SORT_ASCENDING/SORT_DESCENDING constants in favor of literal 1/-1, matching openstack-uicore-foundation's own MUI table. - Remove the unused afterUpdate mechanism (dead since media_uploads editing was removed pre-migration). - Rework formatEventData to spread the raw event instead of overwriting real API fields with display strings under the same key. Since BulkEditTable now sends formatEventData's output straight to bulkUpdateEvents, the previous behavior corrupted start_date, end_date, duration, level, streaming_url/meeting_url/etherpad_link, streaming_type, and location on every bulk save, and could crash on tags. Display-only values now live under new keys (speaker_names, track_name, *_display) wired up via column render functions. - Move formatEventData out of summitUtils.js into summit-event-list-page (its only consumer) and relocate its tests accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/9014802374/86bah61k7