feat: add global --no-color flag and NO_COLOR handling for CLI#18
Merged
feat: add global --no-color flag and NO_COLOR handling for CLI#18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
NO_COLORenvironment variable.Description
--no-coloroption to the Typer app callback insrc/scribae/main.pyand checkNO_COLORinos.environto control coloring at runtime.click.get_current_context(...).color = Falseto disable ANSI coloring when requested, and addimport clickandimport osto support this behavior.tests/unit/main_test.pyto validate colored output,--no-colorflag behavior, andNO_COLORenvironment handling, and ensure tests unsetNO_COLORduring setup withmonkeypatch.delenv.Testing
uv run ruff check src tests, which passed.uv run mypy src, which failed due to unrelated missing stubs fortorchinsrc/scribae/translate/mt.py(2 errors reported).uv run pytest, which passed:163 passed.Codex Task