Skip to content

Add retained evidence boundary posture#648

Open
flyingrobots wants to merge 1 commit into
mainfrom
feature/retained-evidence-boundary-posture
Open

Add retained evidence boundary posture#648
flyingrobots wants to merge 1 commit into
mainfrom
feature/retained-evidence-boundary-posture

Conversation

@flyingrobots

Copy link
Copy Markdown
Owner

Summary

  • Add RetainedEvidenceBoundaryPosture as the observer-facing posture surface above local retained byte references.
  • Split retained evidence boundary state across layer, origin, proof strength, access, completeness, and typed obstruction axes.
  • Preserve missing-retention semantics for true missing coordinates/content while modeling redaction and unsupported evidence kinds separately.
  • Bind obstruction contract evidence into boundary posture ids so contract evidence cannot alias at the boundary.

Validation

  • cargo test -p warp-core --test retained_evidence_ref_tests
  • cargo check
  • cargo fmt --all -- --check
  • git diff --check
  • pre-commit hook: cargo clippy -p warp-core --lib, cargo check -p warp-core, markdownlint
  • pre-push hook: cargo fmt --all -- --check, cargo test -p warp-core --lib, cargo check -p warp-core --quiet, cargo test -p warp-core --test retained_evidence_ref_tests, Prettier markdown check

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@flyingrobots, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 44 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6c3c42c4-c689-4071-8769-eef6081112d7

📥 Commits

Reviewing files that changed from the base of the PR and between 1d8e206 and 177031f.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • crates/warp-core/src/lib.rs
  • crates/warp-core/src/retained_evidence.rs
  • crates/warp-core/tests/retained_evidence_ref_tests.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/retained-evidence-boundary-posture

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 177031fec5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +432 to +434
access,
completeness: RetainedEvidenceCompleteness::Complete,
obstruction: None,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reject obstructing accesses in available_with_access

When callers use this public helper with an obstructing access such as RetainedEvidenceAccess::Unsupported, AuthorityBlocked, or KeyUnavailable, the posture is still marked Complete with obstruction: None, so downstream boundary consumers can treat unsupported or blocked evidence as fully supported instead of the typed obstruction promised by the new API. Restrict this constructor to citation/revealable accesses or route obstructing accesses through constructors that set non-complete/obstructed posture.

Useful? React with 👍 / 👎.

Comment on lines +564 to +566
self.access == RetainedEvidenceAccess::Revealable
&& self.completeness == RetainedEvidenceCompleteness::Complete
&& self.obstruction.is_none()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Require a retained reference before granting reveal

Because all RetainedEvidenceBoundaryPosture fields are public, callers can construct a posture with reference: None, access: Revealable, completeness: Complete, and no obstruction; grants_reveal() then returns true even though there is no retained ref/content descriptor to reveal. Include self.reference.is_some() in this predicate (or otherwise enforce the invariant) so manually projected boundary postures cannot grant byte revelation without known retained bytes.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant