Allow multiple ports to be defined explicitly #1809
Conversation
|
I didn't modify this section in the Istio router, as I am not too sure how it works: // set destination port when an ingress gateway is specified
if canary.Spec.Service.PortDiscovery &&
(len(canary.Spec.Service.Gateways) > 0 &&
canary.Spec.Service.Gateways[0] != "mesh" || canary.Spec.Service.Delegation) {
dest = istiov1beta1.HTTPRouteDestination{
Destination: istiov1beta1.Destination{
Host: host,
Port: &istiov1beta1.PortSelector{
Number: uint32(canary.Spec.Service.Port),
},
},
Weight: weight,
}
}In our case, we have a separate controller running that reconciles the Canary CRs, making some API calls to set the traffic split elsewhere (Istio, Consul, ALB). |
|
@aryan9600 Can you help to trigger the pipelines again? I have read the dev-guide, did the |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1809 +/- ##
===========================================
- Coverage 39.44% 28.43% -11.01%
===========================================
Files 287 287
Lines 22706 22864 +158
===========================================
- Hits 8956 6501 -2455
- Misses 12777 15640 +2863
+ Partials 973 723 -250 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks like the failing test was caused by an unrelated issue: Can retry the pipeline again? Thanks |
Add a `ports` field in the canary service specs that allows full control over port mapping and protocol, as an alternative to port discovery. If the new `ports` field is set, it takes precedence over both the single port fields and port discovery. Fixes fluxcd#927 Signed-off-by: Yap Sok Ann <sokann@gmail.com>
|
Did a rebase after the merging of #1823 that also introduces a new field |
aryan9600
left a comment
aryan9600
left a comment
There was a problem hiding this comment.
thanks for tackling this issue
| Port int32 `json:"port"` | ||
|
|
||
| // Port name of the generated Kubernetes service | ||
| PortName string `json:"portName"` |
There was a problem hiding this comment.
| PortName string `json:"portName"` | |
| PortName string `json:"portName,omitempty"` |
| } | ||
|
|
||
| func (c *KubernetesDefaultRouter) reconcileService(canary *flaggerv1.Canary, name string, podSelector string, metadata *flaggerv1.CustomMetadata) error { | ||
| func (c *KubernetesDefaultRouter) getApexServicePort(canary *flaggerv1.Canary) corev1.ServicePort { |
There was a problem hiding this comment.
i think we can merge this and getDsicoveryServicePorts into one function named something like getDefaultServicePorts?
3 participants
Add a
portsfield in the canary service specs that allows full control over port mapping and protocol, as an alternative to port discovery.If the new
portsfield is set, it takes precedence over both the single port fields and port discovery.Fixes #927