Skip to content

fix(share_plus): downsample iOS share previews off main thread - #4003

Open
ananya-kaul wants to merge 1 commit into
fluttercommunity:mainfrom
ananya-kaul:ananya/share-plus-preview-downsampling
Open

ananya-kaul wants to merge 1 commit into
fluttercommunity:mainfrom
ananya-kaul:ananya/share-plus-preview-downsampling

Conversation

@ananya-kaul

@ananya-kaul ananya-kaul commented Oct 14, 2026 •

Copy link
Copy Markdown

Summary

  • Generate image previews with ImageIO thumbnail downsampling on a utility queue before presenting the iOS share sheet.
  • Reuse the cached thumbnail in the placeholder, thumbnail, and link metadata callbacks so those synchronous callbacks do not decode the full-size image.

Fixes #4001

Verification

  • flutter test in packages/share_plus/share_plus — passed (14 tests, 1 skipped).
  • iOS integration test on a simulator — passed locally (3 tests). A temporary iOS 15 deployment-target override was needed because the installed Xcode no longer accepts iOS 13 as the app target; the override was removed afterward.
  • flutter build ios --no-codesign in the example app — passed with that same temporary deployment-target override.
  • clang-format --dry-run --Werror and git diff --check — passed.
  • GitHub's iOS integration job was cancelled at its 30-minute limit without reporting a test assertion failure.

@ananya-kaul
ananya-kaul marked this pull request as ready for review October 14, 2026 12:37
@ananya-kaul

Copy link
Copy Markdown
Author

Hi, this PR is ready for review. The iOS integration tests passed locally, but GitHub cancelled the iOS job at its 30-minute limit. Could a maintainer review the change and rerun that check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: share_plus decodes full-resolution images on the main thread when preparing iOS share previews

2 participants