Skip to content

fix(device_info_plus): guard iOS vision selector #3832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andyzhshg wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(device_info_plus): guard iOS vision selector #3832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24ee667
fix(device_info_plus): guard iOS vision selector
andyzhshg May 21, 2026
9b5de53
fix(device_info_plus): add FlutterFramework SPM dependency
andyzhshg May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/device_info_plus/device_info_plus/ios/device_info_plus/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,15 @@ let package = Package(
products: [
.library(name: "device-info-plus", targets: ["device_info_plus"])
],
dependencies: [],
dependencies: [
.package(name: "FlutterFramework", path: "../FlutterFramework")
],
targets: [
.target(
name: "device_info_plus",
dependencies: [],
dependencies: [
.product(name: "FlutterFramework", package: "FlutterFramework")
],
resources: [
.process("PrivacyInfo.xcprivacy"),
],
Expand Down
4 changes: 3 additions & 1 deletion .../device_info_plus/ios/device_info_plus/Sources/device_info_plus/FPPDeviceInfoPlusPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ - (void)handleMethodCall:(FlutterMethodCall *)call
}
NSNumber *isiOSAppOnVision = [NSNumber numberWithBool:NO];
if (@available(iOS 26.1, *)) {
isiOSAppOnVision = [NSNumber numberWithBool:[info isiOSAppOnVision]];
if ([info respondsToSelector:@selector(isiOSAppOnVision)]) {
isiOSAppOnVision = [NSNumber numberWithBool:[info isiOSAppOnVision]];
}
}
NSError *error = nil;
NSDictionary *fsAttributes = [[NSFileManager defaultManager] attributesOfFileSystemForPath:NSHomeDirectory() error:&error];
Expand Down
8 changes: 6 additions & 2 deletions packages/device_info_plus/device_info_plus/macos/device_info_plus/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,15 @@ let package = Package(
products: [
.library(name: "device-info-plus", targets: ["device_info_plus"])
],
dependencies: [],
dependencies: [
.package(name: "FlutterFramework", path: "../FlutterFramework")
],
targets: [
.target(
name: "device_info_plus",
dependencies: [],
dependencies: [
.product(name: "FlutterFramework", package: "FlutterFramework")
],
resources: [
.process("PrivacyInfo.xcprivacy"),
]
Expand Down
20 changes: 20 additions & 0 deletions packages/device_info_plus/device_info_plus/test/ios_device_info_native_source_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import 'dart:io';

import 'package:flutter_test/flutter_test.dart';

void main() {
test('guards iOS vision process info selector before invocation', () {
final source = File(
'ios/device_info_plus/Sources/device_info_plus/FPPDeviceInfoPlusPlugin.m',
).readAsStringSync();

final guardIndex = source.indexOf(
'respondsToSelector:@selector(isiOSAppOnVision)',
);
final invocationIndex = source.indexOf('[info isiOSAppOnVision]');

expect(guardIndex, isNonNegative);
expect(invocationIndex, isNonNegative);
expect(guardIndex, lessThan(invocationIndex));
});
}
Loading