fix(android): check manifest declaration instead of grant state for FGS permission (fixes #731) - #733
Merged
Conversation
…GS permission (fixes #731)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requireForegroundServicePermission()inForegroundServiceUtils.ktusedPackageManager.checkPermission(), which reports the runtime grant state — not the manifest declaration. On Android 16+, foreground-service permissions can be revoked/denied at runtime even when declared, so the guard false-positived and threw:…even though the merged manifest clearly declares it (see #731).
The guard now checks the merged manifest declaration instead:
packageManager.getPackageInfo(packageName, PackageManager.GET_PERMISSIONS).requestedPermissions(the set of declared permissions). The loudIllegalStateExceptionwith the same fix hint is kept for genuinely missing declarations.Behavior matrix after the fix:
FOREGROUND_SERVICE_SHORT_SERVICEdeclared (plugin default)workmanager.enableDataSyncForegroundService=trueset (permission declared)Verification
./gradlew :workmanager_android:testDebugUnitTest(via example app, JDK 17): 56 tests, 0 failures — including new tests covering both the declared case (shortService and dataSync) and the missing-declaration case, plus a null-requestedPermissionsedge case.-Pworkmanager.enableDataSyncForegroundService=truebuild: confirmed the plugin swaps in the opt-in manifest andprocessDebugManifestoutput then containsFOREGROUND_SERVICE_DATA_SYNC.flutter build apk --debug(example app): builds clean.ktlint 1.7.1(CI version) on the repo: clean.dart analyze: no issues.Fixes #731