Skip to content

The cursor needs to change when the mouse hovers over each blog category#13630

Open
kjxbyz wants to merge 1 commit into
flutter:mainfrom
kjxbyz:fix/blog-category-hover
Open

The cursor needs to change when the mouse hovers over each blog category#13630
kjxbyz wants to merge 1 commit into
flutter:mainfrom
kjxbyz:fix/blog-category-hover

Conversation

@kjxbyz

@kjxbyz kjxbyz commented Jul 25, 2026

Copy link
Copy Markdown

The new Flutter blog has been merged into the main branch, but the cursor icon doesn't change when the mouse hovers over each blog category tag. I think it should be a pointer, which would be a more user-friendly design.

This is my first PR submission, and I'm not sure if the solution is correct, but it works fine. Thank you.

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@kjxbyz
kjxbyz requested review from a team and sfshaza2 as code owners July 25, 2026 07:04
@google-cla

google-cla Bot commented Jul 25, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a cursor pointer to the button hover state in the blog component's Sass file. The reviewer suggests moving the cursor: pointer style directly to the button element itself rather than applying it only on hover, which improves maintainability and consistency.

&:hover button {
color: var(--site-base-fgColor);
background-color: transparent;
cursor: pointer;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of applying cursor: pointer only when hovering over the parent element (&:hover button), it is more standard and maintainable to define cursor: pointer directly on the button element itself. This ensures the cursor behavior is consistently associated with the button.

Consider removing it from here and adding it to the button rule instead:

  button {
    padding: 0.75rem 0.5rem;

    font-size: 1rem;
    font-weight: 500;
    background-color: transparent;
    color: var(--site-base-fgColor-alt);
    cursor: pointer;
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant