The cursor needs to change when the mouse hovers over each blog category#13630
The cursor needs to change when the mouse hovers over each blog category#13630kjxbyz wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request adds a cursor pointer to the button hover state in the blog component's Sass file. The reviewer suggests moving the cursor: pointer style directly to the button element itself rather than applying it only on hover, which improves maintainability and consistency.
| &:hover button { | ||
| color: var(--site-base-fgColor); | ||
| background-color: transparent; | ||
| cursor: pointer; |
There was a problem hiding this comment.
Instead of applying cursor: pointer only when hovering over the parent element (&:hover button), it is more standard and maintainable to define cursor: pointer directly on the button element itself. This ensures the cursor behavior is consistently associated with the button.
Consider removing it from here and adding it to the button rule instead:
button {
padding: 0.75rem 0.5rem;
font-size: 1rem;
font-weight: 500;
background-color: transparent;
color: var(--site-base-fgColor-alt);
cursor: pointer;
}
The new Flutter blog has been merged into the main branch, but the cursor icon doesn't change when the mouse hovers over each blog category tag. I think it should be a pointer, which would be a more user-friendly design.
This is my first PR submission, and I'm not sure if the solution is correct, but it works fine. Thank you.
Presubmit checklist
of 80 characters or fewer.