-
Notifications
You must be signed in to change notification settings - Fork 3.5k
doc(web): update Wasm status page links and FAQ conditional imports #13622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kevmoo
wants to merge
2
commits into
main
Choose a base branch
from
web-wasm-docs-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -97,8 +97,17 @@ controls the headers on an HTTP request. | |||||||
|
|
||||||||
| Some plugins require platform-specific imports, particularly if they use the | ||||||||
| file system, which is not accessible from the browser. To use these plugins | ||||||||
| in your app, see the [documentation for conditional imports][] | ||||||||
| on [dart.dev]({{site.dart-site}}). | ||||||||
| in your app, use conditional imports. | ||||||||
|
|
||||||||
| When compiling for WebAssembly, check for `dart.library.js_interop` (rather than `dart.library.js` or `dart.library.html`, which are not supported on Wasm): | ||||||||
|
|
||||||||
| ```dart | ||||||||
| import 'fallback.dart' | ||||||||
| if (dart.library.js) 'legacy_web_interop.dart' | ||||||||
| if (dart.library.js_interop) 'wasm_web_interop.dart'; | ||||||||
| ``` | ||||||||
|
|
||||||||
| For more details, see the [documentation for conditional imports][] on [dart.dev]({{site.dart-site}}). | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
|
|
||||||||
| ### Does Flutter web support concurrency? | ||||||||
|
|
||||||||
|
|
@@ -221,7 +230,7 @@ value such as 0 or 60 seconds. | |||||||
|
|
||||||||
| [building a web app with Flutter]: /platform-integration/web/building | ||||||||
| [Creating responsive apps]: /ui/adaptive-responsive | ||||||||
| [documentation for conditional imports]: {{site.dart-site}}/guides/libraries/create-library-packages#conditionally-importing-and-exporting-library-files | ||||||||
| [documentation for conditional imports]: {{site.dart-site}}/interop/js-interop/package-web#conditional-imports | ||||||||
| [Embedding Flutter web]: /platform-integration/web/embedding-flutter-web | ||||||||
| [file an issue]: {{site.repo.flutter}}/issues/new?title=[web]:+%3Cdescribe+issue+here%3E&labels=%E2%98%B8+platform-web&body=Describe+your+issue+and+include+the+command+you%27re+running,+flutter_web%20version,+browser+version | ||||||||
| [`http`]: {{site.pub}}/packages/http | ||||||||
|
|
||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -157,6 +157,10 @@ static JS interop: | |||||||||||||||
| - [`package:web`][], which replaces `dart:html` (and other web libraries) | ||||||||||||||||
| - [`dart:js_interop`][], which replaces `package:js` and `dart:js` | ||||||||||||||||
|
|
||||||||||||||||
| For a detailed guide on migrating existing code, see the [`package:web` migration guide][]. | ||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||
|
|
||||||||||||||||
| When compiling to Wasm, be aware of runtime differences in JS interop types (such as `is`/`as` type casts and Zone propagation in callbacks). For details, see Dart's [JS interop types documentation]({{site.dart-site}}/interop/js-interop/js-types#compatibility-type-checks-and-casts) and the [package:web Zones section]({{site.dart-site}}/interop/js-interop/package-web#zones). | ||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||
|
|
||||||||||||||||
| To learn more about JS interop in Dart, | ||||||||||||||||
| see Dart's [JS interop][] documentation page. | ||||||||||||||||
|
|
||||||||||||||||
|
|
||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.