docs: remove outdated iOS C interop page and fix references#13337
Conversation
|
Hi! I’ve removed the outdated iOS C interop page and cleaned up related references to avoid broken links. Please let me know if anything else needs adjustment. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the legacy iOS C interop documentation and cleans up associated links and references across several files. Feedback indicates that removing the reference definitions in the Android and macOS interop pages results in broken links within the introductory notes of those files, as the text still attempts to reference the deleted iOS content.
|
Visit the preview URL for this PR (updated for commit 4f17b0d): https://flutter-docs-prod--pr13337-remove-c-interop-docs-jtz06zdf.web.app |
|
Good catch, thanks |
|
Hi! Just a gentle follow-up on this PR. Please let me know if any further changes are needed from my side. Happy to update it. Thanks! |
|
Hi, @harshyadavDeveloper, I'm waiting for the next stable release. That's when these changes are live. |
|
@sfshaza2 Just following up on this PR — the latest stable release is out now, so I wanted to check if this is ready for another look when you have time. Thanks! |
|
/gcbrun FYI, @harshyadavDeveloper, I'm working at Google I/O, so I am online very little this week. :) |
|
@parlough, can you take this PR? It has some conflicts, given our migration... |
|
@harshyadavDeveloper, could you resolve the conflicts here? You created this PR before a major restructuring of the website. Another reason I don't like PRs to sit around for too long, but it was too early to land this before. :) |
docs: remove broken ios-ffi references after page removal
harshyadavDeveloper
force-pushed
the
remove-c-interop-docs
branch
from
4f17b0d to
96b874f
Compare
|
@sfshaza2 I've resolved the merge conflicts and rebased the branch onto the latest main. Could you please take another look when you have a chance? Thanks! |
parlough
left a comment
parlough
left a comment
There was a problem hiding this comment.
A redirect is needed and I left some suggestions, but then looks good to me. Thanks for tackling this @harshyadavDeveloper!
|
@parlough Thanks for the review! I've addressed the feedback:
Could you take another look when you have a chance? |
|
Staged preview of the updated docs.flutter.dev site (updated for commit 12c2a91): https://flutter-docs-prod--docs-pr13337-remove-c-interop-docs-sxuwdju0.web.app |
parlough
left a comment
parlough
left a comment
There was a problem hiding this comment.
Thanks for those adjustments. Looks good to me!
4 participants
Description
Removes the outdated iOS C interop documentation page and updates references across the site.
The page referenced CocoaPods, which is no longer the recommended approach now that Swift Package Manager is the default. Removing this page avoids confusion and broken links.
Issues fixed by this PR
Closes #13313
PRs or commits this PR depends on
None
Presubmit checklist