Skip to content

Henry rubato tests#2852

Closed
henry-domingo wants to merge 2 commits into
flutter:mainfrom
henry-domingo:henry-rubato-tests
Closed

Henry rubato tests#2852
henry-domingo wants to merge 2 commits into
flutter:mainfrom
henry-domingo:henry-rubato-tests

Conversation

@henry-domingo
Copy link
Copy Markdown

Summary

This PR adds a new end-to-end integration test for the booking journey and documents both the test flow and architecture notes.

What changed

  1. Added a new integration test covering the auth-gated local booking flow:
  • Starts logged out and verifies Login screen is shown.
  • Logs in through a test auth repo override.
  • Completes booking creation flow.
  • Returns Home and verifies the newly created booking is visible.
  1. Updated documentation with:
  • How to run this new integration test.
  • Architecture walkthrough notes (state-to-UI trace, routing/auth gate behavior, data boundaries, and suggested enhancement).
  • Answers to Part 2 and 4 questions.

Key choices and why

  1. Used local providers for known test behavior.
  • Chose local data path to avoid network/server issues - confining to app's logic
  1. Overrode only the auth repository in test setup.
  • This keeps routing, VMs, and booking flow intact while still controlling login state transitions.
  • Cleared shared preferences at test start.
  • Ensures a consistent logged-out initial state so the test remains repeatable.
  1. Added explicit screen/state assertions at each major step.
  • Makes failures easier to notice and provides assurance in flow coverage.

How to run

  • Refer to the branch's README

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jun 5, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants