Skip to content

Fix readme typos #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anshulyadavv wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix readme typos #2832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8da01ae
docs: Add disposal clarification to HomeViewModel
anshulyadavv Apr 17, 2026
fa68602
docs: Fix grammatical and typographical errors in README
anshulyadavv Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ We appreciate fixes and necessary improvements to existing samples. **But in mos

Please read the [contributor's guide] if you have contributions.

Googler's, you can freely add samples to the [flutter/demos] repository.
Googlers, you can freely add samples to the [flutter/demos] repository.

## Index

Expand All @@ -36,7 +36,7 @@ Googler's, you can freely add samples to the [flutter/demos] repository.

### Native platform samples

* [`add-to-app`] - Collection of samples that demonstrate embedding Flutter a view into a native app.
* [`add-to-app`] - Collection of samples that demonstrate embedding a Flutter view into a native app.
* [`fullscreen`] — Embeds a full screen instance of
Flutter into an existing iOS or Android app.
* [`prebuilt_module`] — Embeds a full screen
Expand Down Expand Up @@ -81,7 +81,7 @@ There are two types of sample code in this repository:

* **Quickstarts** provide a starting point to extend. They answer the question,
"What is the minimal amount of code needed to implement this feature?"
* **Demo apps** are meant to be built and ran. They demo the _product_,
* **Demo apps** are meant to be built and run. They demo the _product_,
not how to write code.

A majority of samples in this repository are quickstarts.
Expand Down
3 changes: 3 additions & 0 deletions compass_app/app/lib/routing/router.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ GoRouter router(AuthRepository authRepository) => GoRouter(
GoRoute(
path: Routes.home,
builder: (context, state) {
// Note: HomeViewModel currently does not require disposal.
// If disposable resources are introduced, lifecycle ownership
// would need to be addressed (e.g. via Provider/Riverpod or a StatefulWidget).
final viewModel = HomeViewModel(
bookingRepository: context.read(),
userRepository: context.read(),
Expand Down