feat(rfc_tools): add RFC frontmatter and file markdown models - #8
Open
jtmcdole wants to merge 3 commits into
Open
feat(rfc_tools): add RFC frontmatter and file markdown models#8jtmcdole wants to merge 3 commits into
jtmcdole wants to merge 3 commits into
Conversation
jtmcdole
force-pushed
the
pr-3-frontmatter-models
branch
2 times, most recently
from
September 4, 2026 17:13
9781ddb to
c5ac319
Compare
jtmcdole
marked this pull request as ready for review
September 4, 2026 17:16
jtmcdole
force-pushed
the
pr-3-frontmatter-models
branch
from
September 4, 2026 19:33
c5ac319 to
f84b206
Compare
zanderso
reviewed
Sep 4, 2026
zanderso
left a comment
zanderso
left a comment
Member
There was a problem hiding this comment.
Not sure since the frontmatter isn't too long, but would it be helpful to include file line numbers in the error messages?
jtmcdole
force-pushed
the
pr-3-frontmatter-models
branch
from
September 4, 2026 22:35
f84b206 to
1e8f7aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 3 of 7 for testing and automation
RfcFile and RfcFrontmatter are the core models of parsing and validating.
Stack created with GitHub Stacks CLI • Give Feedback 💬