Repository navigation
[tabs_overlay] Migrate to material_ui - #239
Merged
Merged
Conversation
pjkammer
changed the title
4 of 8 tasks
Generated with `flutter pub add material_ui` (Flutter 3.47.7), which picked ^1.7.0. No hand edits. The lock also gains material_ui's dependencies it didn't have already (cupertino_ui, flutter_localizations, intl), and its Flutter floor rises to >=3.47.0 because material_ui requires Flutter 3.47. Nothing imports material_ui yet. That happens in a subsequent commit.
Generated with `dart fix --apply --code=migrate_design_widgets` (Dart 3.13.5). No hand edits.
pjkammer
force-pushed
the
tabs-overlay-material-ui
branch
from
October 21, 2026 17:19
81b453a to
51957e4
Compare
pjkammer
marked this pull request as ready for review
October 21, 2026 17:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates tabs_overlay from
package:flutter/material.darttopackage:material_ui/material_ui.dart, where the Material widgets are developed now, so the app compares the platform's tab view with theTabBarViewthe team works on.Commits, both unmodified tool output:
flutter pub add material_ui, which addsmaterial_ui: ^1.7.0. material_ui requires Flutter 3.47.dart fix --apply --code=migrate_design_widgetsswitcheslib/main.dart, the only file that importedmaterial.dart.Appearance on an iPhone 17 Pro simulator (iOS 26.4) and a Pixel 8 emulator (Android 17) is the same before and after the change. Each pair of recordings below replays the same scripted gestures before and after.
iOS, swiping to tab 2 and back:
ios_before.mp4
ios_after.mp4
Android, tapping the native TAB 2 and swiping back:
android_before.mp4
android_after.mp4
Tested with Flutter 3.47.7:
flutter analyze,flutter testanddart formatare clean, nopackage:flutter/material.dartimport is left, and the integration test passes on both devices.Part of flutter/flutter#172942
Pre-launch Checklist
I signed the CLA.I updated/added relevant documentation (doc comments with///).The existing widget and integration smoke tests cover the change: both run the app, which now builds its tabs from material_ui.
No CI runs tests here. Locally,
flutter testpasses, and the integration test passes on iOS and Android.If you need help, consider asking for advice on the #hackers-new channel on Discord.