[material_ui] Add the Material shapes. - #12771
Open
ksokolovskyi wants to merge 60 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a shapes library for creating and morphing rounded polygonal shapes, including classes such as RoundedPolygon, CornerRounding, CubicBezier, Feature, and Morph, along with predefined Material Design shapes in MaterialShapes and a MaterialShapeBorder class. Feedback on these changes highlights several issues: an invalid enum syntax in the example painter, potential division-by-zero or NaN bugs in LengthMeasurer and RoundedPolygon.normalized, a typo and incorrect parameter name in an error message, and performance optimization opportunities in Morph.toCubics and CubicBezier operators to avoid list allocations.
…th toStringAsFixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the Material shapes library to
material_ui, a Dart port of the AndroidX graphics-shapes library and the Compose MaterialShapes catalog. These APIs are the foundation for upcoming M3 Expressive components (loading indicator, wavy progress indicators, etc.) and let app developers use the Material shape catalog and shape-morphing animations directly.New public API:
RoundedPolygon,CornerRounding,CubicBezier,Feature: creation and transformation of rounded polygonal shapes.Morph: smooth morphing between twoRoundedPolygons.MaterialShapes: the catalog of 35 predefined Material Design shapes (pictured below).MaterialShapeBorder: anOutlinedBorderthat draws aRoundedPolygon, so the shapes plug into the existingShapeDecoration/shapeAPIs and animate through the usual border lerping.The port keeps the geometry and behavior of the Kotlin original (unit tests are ported from AndroidX alongside new ones), while adapting the API surface to Dart/Flutter conventions. Every shape in
MaterialShapes.allis covered by a golden test. Also includes a new example that morphs through the whole catalog.Closes flutter/flutter#192353
Shapes catalog
Example
material_shapes_example.mov
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2