[google_maps_flutter] Convert remaining code to Swift - #12768
Open
stuartmorgan-g wants to merge 14 commits into
Open
[google_maps_flutter] Convert remaining code to Swift#12768stuartmorgan-g wants to merge 14 commits into
stuartmorgan-g wants to merge 14 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request converts the remaining Objective-C code to Swift for both the google_maps_flutter_ios_sdk9 and google_maps_flutter_ios_sdk10 packages. This includes updating the Pigeon configuration to generate Swift code, removing Objective-C files, and refactoring Swift implementation and test files to use the new Swift-generated Pigeon APIs. Two minor typos were identified in the changelog files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts remaining code to Swift:
NSObjectconformance from cases where it's no longer necessary. (Class that implement Flutter plugin API protocols still need it, as those are Obj-C protocols.)Unlike the other PRs, this does not contain any Gemini Obj-C -> Swift conversions (other than some simple protocols); this is mostly just a Pigeon generation change and a lot of mostly mechanical cleanup.
Fixes flutter/flutter#119108
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2