Skip to content

[camera_windows] Fall back to temp dir for capture path. - #12755

Open
llfbandit wants to merge 2 commits into
flutter:mainfrom
llfbandit:camera_windows-capture-dir-fallback
Open

[camera_windows] Fall back to temp dir for capture path.#12755
llfbandit wants to merge 2 commits into
flutter:mainfrom
llfbandit:camera_windows-capture-dir-fallback

Conversation

@llfbandit

Copy link
Copy Markdown

Fixes flutter/flutter#192302

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

No test added since there's actually no test on this path.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Windows camera plugin to fall back to the system temp directory for saving captured pictures and videos when the standard Pictures or Videos known folders cannot be resolved. The feedback suggests updating a comment to clarify that this fallback will not be triggered if SHGetKnownFolderPath succeeds but write access is blocked, such as by Controlled Folder Access.

Comment thread packages/camera/camera_windows/windows/camera_plugin.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[camera_windows] Fallback to temp dir when Pictures / Videos known folder cannot be resolved.

1 participant