[material_ui] Use ColorScheme.scrim for modal barrier/scrim defaults - #12746
Open
byshy wants to merge 3 commits into
Open
[material_ui] Use ColorScheme.scrim for modal barrier/scrim defaults#12746byshy wants to merge 3 commits into
byshy wants to merge 3 commits into
Conversation
Enhance the handling of modal barrier colors in bottom sheets, dialogs, and drawers to utilize ColorScheme.scrim with an opacity matching Colors.black54 when no specific color is provided. This change ensures a consistent appearance across components and allows for better theme integration. Additionally, tests have been added to verify the new behavior and precedence rules for barrier colors.
10 tasks
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the default fallback colors for dialog, modal bottom sheet, and drawer barriers/scrims to use ColorScheme.scrim with an opacity matching Colors.black54 when no explicit color or theme-specific color is provided. It also updates the corresponding documentation, adds a pending changelog entry, and introduces comprehensive widget tests to verify the new fallback behavior and precedence rules. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When modal barrier or drawer scrim colors are not set via an explicit parameter or component theme, fall back to
ColorScheme.scrimwith an opacity matchingColors.black54instead of hardcodingColors.black54.This allows apps that customize
ColorScheme.scrimto theme dialog, modal bottom sheet, and drawer scrims consistently, while preserving the default appearance for the standard black scrim token.Fallback order remains:
barrierColor/drawerScrimColor)DialogTheme,BottomSheetTheme,DrawerTheme)Theme.of(context).colorScheme.scrim.withValues(alpha: Colors.black54.a)Ports flutter/flutter#190911
Work towards flutter/flutter#188444
Fixes flutter/flutter#190824
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2