Skip to content

[infra] Use a modified no-response workflow in flutter/packages - #12745

Open
elliette wants to merge 3 commits into
flutter:mainfrom
elliette:issue-191756
Open

[infra] Use a modified no-response workflow in flutter/packages#12745
elliette wants to merge 3 commits into
flutter:mainfrom
elliette:issue-191756

Conversation

@elliette

@elliette elliette commented Sep 3, 2026

Copy link
Copy Markdown
Member

Resolves flutter/flutter#191756

Allows us to use the waiting for response label on PRs. PRs with that label will be auto-closed after 21 days of no response.

Copies the existing flutter/flutter no-response.yaml and no-response.js files to flutter/packages, but removes all the issue-specific logic since issues are disabled on flutter/packages so we only need this to work for PRs.

Pre-Review Checklist

Test exemption: Github workflow change.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@elliette elliette added the CICD Run CI/CD label Sep 3, 2026
@elliette
elliette marked this pull request as ready for review September 3, 2026 22:01

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new GitHub Actions script, .github/scripts/no-response.js, which automates the closure of inactive pull requests labeled 'waiting for response' after 21 days. Feedback on this implementation suggests optimizing API usage by setting per_page: 100 across all paginated requests to prevent rate limiting. Additionally, the feedback recommends using optional chaining to safeguard against runtime errors when accessing nested properties of events and commits, and addressing a potential bug where deleted users could falsely trigger response detection.

Comment thread .github/scripts/no-response.js
Comment thread .github/scripts/no-response.js
Comment thread .github/scripts/no-response.js
Comment thread .github/scripts/no-response.js
Comment thread .github/scripts/no-response.js
Comment thread .github/scripts/no-response.js
Comment thread .github/scripts/no-response.js

@tarrinneal tarrinneal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good :)

Comment thread .github/scripts/no-response.js
Comment thread .github/scripts/no-response.js
Comment thread .github/workflows/no-response.yaml Outdated
Comment on lines +9 to +10
# Schedule for every 15 minutes.
- cron: '*/15 * * * *'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the norm is for our cron length for this type of thing, but I feel like every 15 minutes is a bit more than necessary. nbd probably

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped to every 30 mins. 15 is what flutter/flutter is currently using for this label, we can switch down to 15 if the lag between when a contributor responds on a PR and when the label is removed is too slow.

@elliette elliette added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 4, 2026
@auto-submit

auto-submit Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12745, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add waiting for response label/workflow to flutter/packages

2 participants