[infra] Use a modified no-response workflow in flutter/packages - #12745
[infra] Use a modified no-response workflow in flutter/packages#12745elliette wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new GitHub Actions script, .github/scripts/no-response.js, which automates the closure of inactive pull requests labeled 'waiting for response' after 21 days. Feedback on this implementation suggests optimizing API usage by setting per_page: 100 across all paginated requests to prevent rate limiting. Additionally, the feedback recommends using optional chaining to safeguard against runtime errors when accessing nested properties of events and commits, and addressing a potential bug where deleted users could falsely trigger response detection.
| # Schedule for every 15 minutes. | ||
| - cron: '*/15 * * * *' |
There was a problem hiding this comment.
I don't know what the norm is for our cron length for this type of thing, but I feel like every 15 minutes is a bit more than necessary. nbd probably
There was a problem hiding this comment.
Bumped to every 30 mins. 15 is what flutter/flutter is currently using for this label, we can switch down to 15 if the lag between when a contributor responds on a PR and when the label is removed is too slow.
|
autosubmit label was removed for flutter/packages/12745, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Resolves flutter/flutter#191756
Allows us to use the
waiting for responselabel on PRs. PRs with that label will be auto-closed after 21 days of no response.Copies the existing flutter/flutter
no-response.yamlandno-response.jsfiles to flutter/packages, but removes all the issue-specific logic since issues are disabled on flutter/packages so we only need this to work for PRs.Pre-Review Checklist
[shared_preferences]///).Test exemption: Github workflow change.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2