[cupertino_ui] Fix platform view sheet transitions - #12565
Open
laishere wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a hasPlatformViews parameter to Cupertino sheet transitions, routes, and helper functions to ensure platform views remain synchronized during transitions by disabling image-filtered scaling. It also includes corresponding unit tests and a changelog entry. A review comment suggests using scrollableBuilder instead of the deprecated pageBuilder in the new tests.
9 tasks
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
victorsanni
reviewed
Aug 26, 2026
victorsanni
self-requested a review
August 31, 2026 17:46
Author
|
Here's the subpixel issue I mentioned about when using TransformLayer. Raster.Drift.Comparison.When.Scaling.mp4 |
victorsanni
approved these changes
Sep 1, 2026
Author
|
@dkwingsmt It shows one workflow awaiting approval. Is it required? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From flutter/flutter#182935
Fixes flutter/flutter#169495
The scale transition in showCupertinoSheet for the underlying route defaulted to FilterQuality.medium, which pushes an implicit
ImageFilterLayer.Platform views cannot be correctly sampled or transformed by rasterization-based filters. Consequently, they fail to reflect the scale transformation during the transition animation when an
ImageFilterLayeris present, leading to a broken visual effect where the background scales but the platform view remains at its original size.Solution:
Added
hasPlatformViewparameter.falseby default which matches the original behavior. When set totrue, we use standardTransformLayerby setting filterQuality tonull.Pre-Review Checklist
[shared_preferences]///).