[material_ui] Fix ExpansionTile nested WidgetSpan semantics assertion - #12383
Closed
ahamSel wants to merge 1 commit into
Closed
[material_ui] Fix ExpansionTile nested WidgetSpan semantics assertion#12383ahamSel wants to merge 1 commit into
ahamSel wants to merge 1 commit into
Conversation
Contributor
|
Hi @ahamSel thanks for contributing! This package is not accepting contributions yet, so I am going to close this PR for now. We will be letting folks know when we are ready for contributions, the PR you have open in flutter/flutter is perfect. We'll be letting everyone know there when we are ready. Thanks! |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #12765, which contains the rebased fix and the simpler test requested in flutter/flutter#190639. This PR remains closed because GitHub cannot reopen it after the branch was rebased. The description and validation below refer to this PR's original diff.
On Android,
ExpansionTilewraps its tile in a live-regionSemanticsnode that usesAccessibilityFocusBlockType.blockNode. When the title contains a nestedWidgetSpan, that live region can merge into the surrounding semantics tree and trigger a sibling-configuration conflict assertion.This makes the live region a semantics container, so
blockNodeapplies to an explicit node. It also adds an Android regression test using the reported nestedWidgetSpanstructure. The test fails with the original!conflictassertion when the production change is removed and passes with the fix.Fixes flutter/flutter#188298.
This ports flutter/flutter#190639 to
material_ui, where Material development is moving during the framework code freeze.Pre-Review Checklist
[shared_preferences]///).Validation performed:
flutter test test/expansion_tile_test.dartflutter analyze lib/src/expansion_tile.dart test/expansion_tile_test.dartThe release metadata uses
material_ui's batch-release convention: a pending changelog entry withversion: patch.Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2