[google_maps_flutter] Add onPointOfInterestTap callback by tenninebt · Pull Request #11872 · flutter/packages

tenninebt · 2026-06-08T18:01:27Z

Adds GoogleMap.onPointOfInterestTap, a callback that fires when the user taps a built-in map point of interest. The callback receives a PointOfInterestId containing the place ID only, matching maintainer feedback on #4052 and #10963.

The change is wired through the federated plugin stack: platform_interface (type + event stream), Android (OnPoiClickListener), iOS including sdk9/sdk10/shared (didTapPOIWithPlaceID), web (IconMouseEvent.placeId on map click), and the app-facing google_maps_flutter package. Tests cover Dart unit tests, Android Robolectric, iOS native, and web integration tests in the web example.

Fixes flutter/flutter#60695

Pre-Review Checklist

gemini-code-assist

Code Review

This pull request adds support for tapping points of interest (POIs) on the map across Android, iOS, and Web platforms in the google_maps_flutter plugin. It introduces the PointOfInterestId type and PointOfInterestTapEvent in the platform interface, exposes the onPointOfInterestTap callback on the GoogleMap widget, and implements the platform-specific event handling and Pigeon messaging. The review feedback suggests adding a defensive null check for the PointOfInterest parameter in the Android onPoiClick handler to prevent a potential NullPointerException.

gemini-code-assist · 2026-06-13T07:33:15Z

+  public void onPoiClick(PointOfInterest pointOfInterest) {
+    if (pointOfInterest.placeId != null) {
+      flutterApi.onPointOfInterestTap(
+          pointOfInterest.placeId, (Result<Unit> result) -> Unit.INSTANCE);
+    }
+  }


Defensively checking pointOfInterest for null before accessing its properties is a good practice to prevent potential NullPointerExceptions, especially since the parameter is not annotated with @NonNull.

Suggested change

public void onPoiClick(PointOfInterest pointOfInterest) {

if (pointOfInterest.placeId != null) {

flutterApi.onPointOfInterestTap(

pointOfInterest.placeId, (Result<Unit> result) -> Unit.INSTANCE);

}

}

public void onPoiClick(PointOfInterest pointOfInterest) {

if (pointOfInterest != null && pointOfInterest.placeId != null) {

flutterApi.onPointOfInterestTap(

pointOfInterest.placeId, (Result<Unit> result) -> Unit.INSTANCE);

}

}

The placeId null guard is the important part, and it’s already there. The Maps SDK only calls onPoiClick with a non-null PointOfInterest when a POI is tapped, and the other click handlers in this class don’t null-check their parameters either. We already have a test for the realistic case (placeId == null), which matches iOS. An extra pointOfInterest != null check would be harmless but unnecessary.

Fair enough.

tenninebt · 2026-07-04T16:53:36Z

Hi @stuartmorgan-g when you're ready to review ping me and I'll do it right away. I'd rather fix the conflicts onces and for all instead of doing it every commit on that part of the code ;).

stuartmorgan-g · 2026-07-06T19:26:17Z

No need to resolve changelog/pubspec comments until the whole review process is essentially complete (per the FAQ) since the conflicts in those files don't affect the ability to review the changes.

stuartmorgan-g · 2026-07-06T19:44:49Z

 - (void)didLongPressAtPosition:(FGMPlatformLatLng *)position;

+/// Called when a point of interest is tapped.
+- (void)didTapPointOfInterestWithPlaceId:(NSString *)placeId;


...WithPlaceIdentifier:

Renamed. I also moved the declaration up so it sits in the same spot as the matching method in MapsCallbackApi.

stuartmorgan-g · 2026-07-06T19:45:48Z

  void onCircleTap(String circleId);

+  /// Called when a point of interest is tapped.
+  @ObjCSelector('didTapPointOfInterestWithPlaceId:')


...PlaceIdentifier:

Done, it's didTapPointOfInterestWithPlaceIdentifier: now.

Expose a place-ID-only POI tap stream across the federated plugin stack (Android, iOS, web) so apps can react when users tap built-in map POIs. Fixes flutter/flutter#60695

stuartmorgan-g

Looks good structurally; passing off to platform teams for in-depth platform-level reviews.

One question about the web implementation though.

stuartmorgan-g · 2026-08-10T16:42:58Z


+/// Fake implementation of FGMMapsCallbackApiProtocol that records the calls it receives.
+class MockMapsCallbackApi: NSObject, FGMMapsCallbackApiProtocol {
+  var lastTappedPointOfInterestPlaceIdentifier: String?


Longer term this object may need to take callbacks instead of recording values, to allow for more flexible tests, but this is probably fine for now.

Fair point — I'll keep that in mind if we need more flexible tests down the line. Leaving it as-is for now since it covers what we need.

stuartmorgan-g · 2026-08-10T16:51:33Z

 import 'dart:async';
 import 'dart:convert';
 import 'dart:js_interop';
+import 'dart:js_interop_unsafe';


Why do we need this? Is there a property that needs to be added to google_maps? If so, that should be done upstream rather than worked around here.

I agree. The placeId property should be added upstream. Or defined here using normal JS interop:

extension PlaceIdExtension on gmaps.MapMouseEventOrIconMouseEvent { external String? placeId; }

You're right, we don't need unsafe interop here. I added a local placeId extension on MapMouseEventOrIconMouseEvent (same approach @mdebbar suggested) and read that directly in the click handler. Upstream would still be cleaner long term, but this gets us off dart:js_interop_unsafe for now.

mdebbar

Web changes look good to me but we should try to eliminate the use of dart:js_interop_unsafe.

mdebbar · 2026-08-11T18:40:23Z

 import 'dart:async';
 import 'dart:convert';
 import 'dart:js_interop';
+import 'dart:js_interop_unsafe';


I agree. The placeId property should be added upstream. Or defined here using normal JS interop:

extension PlaceIdExtension on gmaps.MapMouseEventOrIconMouseEvent { external String? placeId; }

vashworth

iOS side LGTM

camsim99

Android implementation LGTM!

camsim99 · 2026-08-31T18:15:41Z

+  public void onPoiClick(PointOfInterest pointOfInterest) {
+    if (pointOfInterest.placeId != null) {
+      flutterApi.onPointOfInterestTap(
+          pointOfInterest.placeId, (Result<Unit> result) -> Unit.INSTANCE);
+    }
+  }


Fair enough.

mdebbar

Web changes look good!

stuartmorgan-g · 2026-09-03T15:45:47Z

Now that this has all the platform team sign-offs, please go ahead and make the first sub-PR with the platform interface changes.

tenninebt · 2026-09-04T16:04:24Z

Opened the platform interface sub-PR as requested: #12752

…safe MapMouseEventOrIconMouseEvent only exposes latLng upstream, so add a local external placeId getter and use that in the click handler instead of hasProperty + cast.

github-actions Bot added p: google_maps_flutter platform-android platform-ios platform-web labels Jun 8, 2026

tenninebt force-pushed the google-maps-on-poi-tap branch 9 times, most recently from 336fb13 to e125948 Compare June 13, 2026 07:30

tenninebt marked this pull request as ready for review June 13, 2026 07:31

gemini-code-assist Bot reviewed Jun 13, 2026

View reviewed changes

stuartmorgan-g self-requested a review June 23, 2026 18:26

stuartmorgan-g requested changes Jul 6, 2026

View reviewed changes

tenninebt force-pushed the google-maps-on-poi-tap branch 3 times, most recently from 1a982ab to 2247d7a Compare July 30, 2026 16:22

[google_maps_flutter] Add onPointOfInterestTap callback

1215581

Expose a place-ID-only POI tap stream across the federated plugin stack (Android, iOS, web) so apps can react when users tap built-in map POIs. Fixes flutter/flutter#60695

tenninebt force-pushed the google-maps-on-poi-tap branch from 2247d7a to 1215581 Compare July 30, 2026 16:33

tenninebt requested a review from stuartmorgan-g July 30, 2026 16:36

stuartmorgan-g added triage-ios Should be looked at in iOS triage triage-android Should be looked at in Android triage labels Aug 10, 2026

stuartmorgan-g requested review from LongCatIsLooong, reidbaker and vashworth August 10, 2026 16:37

stuartmorgan-g added federated: all_changes PR that contains changes for all packages for a federated plugin change triage-web Should be looked at in web triage labels Aug 10, 2026

stuartmorgan-g requested a review from mdebbar August 10, 2026 16:49

stuartmorgan-g reviewed Aug 10, 2026

View reviewed changes

stuartmorgan-g added the CICD Run CI/CD label Aug 10, 2026

mdebbar reviewed Aug 11, 2026

View reviewed changes

flutter-dashboard Bot removed the CICD Run CI/CD label Aug 24, 2026

tenninebt requested review from mdebbar and stuartmorgan-g August 24, 2026 19:18

vashworth approved these changes Aug 25, 2026

View reviewed changes

reidbaker requested review from a team and camsim99 and removed request for a team and reidbaker August 27, 2026 19:58

camsim99 approved these changes Aug 31, 2026

View reviewed changes

mdebbar approved these changes Sep 2, 2026

View reviewed changes

tenninebt mentioned this pull request Sep 4, 2026

[google_maps_flutter_platform_interface] Add onPointOfInterestTap support #12752

Open

11 tasks

tenninebt force-pushed the google-maps-on-poi-tap branch from c023adc to 62ef656 Compare September 4, 2026 16:05

[google_maps_flutter_web] Read POI placeId without dart:js_interop_un…

954c841

…safe MapMouseEventOrIconMouseEvent only exposes latLng upstream, so add a local external placeId getter and use that in the click handler instead of hasProperty + cast.

tenninebt force-pushed the google-maps-on-poi-tap branch from 62ef656 to 954c841 Compare September 4, 2026 16:06

Uh oh!

Conversation

tenninebt commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jun 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tenninebt commented Jul 4, 2026

Uh oh!

stuartmorgan-g commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdebbar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vashworth left a comment

Choose a reason for hiding this comment

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdebbar left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Sep 3, 2026

Uh oh!

tenninebt commented Sep 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tenninebt commented Jun 8, 2026 •

edited

Loading

stuartmorgan-g commented Jul 6, 2026 •

edited

Loading