[camera_avfoundation] Move camera_avfoundation to Darwin#11847
Open
Mairramer wants to merge 3 commits into
Open
[camera_avfoundation] Move camera_avfoundation to Darwin#11847Mairramer wants to merge 3 commits into
Mairramer wants to merge 3 commits into
Conversation
…tep1-darwin-rename # Conflicts: # packages/camera/camera_avfoundation/pigeons/messages.dart
There was a problem hiding this comment.
Code Review
This pull request moves the camera_avfoundation package source files to a shared Darwin directory. It updates the Pigeon Swift output path to the new darwin directory, adds sharedDarwinSource: true to the iOS plugin configuration in pubspec.yaml, and documents the change in the changelog. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the
camera_avfoundationplugin implementation to Darwin, aiming to consolidate the shared AVFoundation codebase for both iOS and macOS platforms.Part of flutter/flutter#41708
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2