Skip to content

[google_maps_flutter_ios_sdk9] Fix title in google maps sdk9 readme#11826

Open
Hari-07 wants to merge 3 commits into
flutter:mainfrom
Hari-07:google-maps-flutter-sdk9-doc
Open

[google_maps_flutter_ios_sdk9] Fix title in google maps sdk9 readme#11826
Hari-07 wants to merge 3 commits into
flutter:mainfrom
Hari-07:google-maps-flutter-sdk9-doc

Conversation

@Hari-07
Copy link
Copy Markdown
Contributor

@Hari-07 Hari-07 commented Jun 3, 2026

Google maps sdk9 readme had a typo where it said sdk10 instead in the title

List which issues are fixed by this PR. You must list at least one issue.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the header in the README.md file for the google_maps_flutter_ios_sdk9 package to correctly reference 'sdk9' instead of 'sdk10'. There are no review comments, and I have no feedback to provide.

@stuartmorgan-g
Copy link
Copy Markdown
Collaborator

Oops, I must have had the wrong tab open when I was editing the copy, and then later thought I just hadn't changed the title in sdk10 and fixed it there without realizing I'd changed it in the wrong place earlier. (I'm surprised Gemini didn't catch this in the autoreview; usually it's good at that kind of mistake.)

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

Even a typo fix should have an actual PR description.

This doesn't need an issue, and it's fine for project members to use judgement on following the checklist, but please don't check things you haven't done as it makes things confusing.

This wasn't done either, and is not optional; it's why CI is failing.

@Hari-07
Copy link
Copy Markdown
Contributor Author

Hari-07 commented Jun 3, 2026

Yeah apologies, I thought it was a small enough change that I kinda just checked everything without reading it. Fixing now

@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 3, 2026
@stuartmorgan-g
Copy link
Copy Markdown
Collaborator

This is still missing the actual version bump in pubspec.yaml.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants