Skip to content

Update go_router type safe route docs to reflect that the generated mixins are now public#11814

Open
LiamKearn wants to merge 1 commit into
flutter:mainfrom
LiamKearn:patch-1
Open

Update go_router type safe route docs to reflect that the generated mixins are now public#11814
LiamKearn wants to merge 1 commit into
flutter:mainfrom
LiamKearn:patch-1

Conversation

@LiamKearn
Copy link
Copy Markdown

Title says all.

REF: #9626

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jun 1, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions Bot added p: go_router triage-framework Should be looked at in framework triage labels Jun 1, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation in packages/go_router/doc/type-safe-routes.md to use $HomeScreenRoute and $SongRoute instead of _$HomeScreenRoute and _$SongRoute. No review comments were provided, and I have no feedback to provide.

@stuartmorgan-g
Copy link
Copy Markdown
Collaborator

@chunhtai I would recommend requiring that this adopt snippets as part of the fix, rather than just changing the text without fixing the underlying problem that there's no verification that the code is accurate.

@stuartmorgan-g stuartmorgan-g requested a review from chunhtai June 2, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: go_router triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants