-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[two_dimensional_scrollables] Activate leak testing and fix memory leaks #11653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ValentinVignal
wants to merge
11
commits into
flutter:main
Choose a base branch
from
ValentinVignal:tow-dimensional-scrollables/fix-memory-leaks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e9a8191
Activate leak testing
ValentinVignal 1a2a5b4
fix memory leaks
ValentinVignal f6dd90e
Update tests
ValentinVignal b5eff12
Update version number
ValentinVignal 90f11e6
Add memory leak test in example
ValentinVignal ac4466b
Gemini comments
ValentinVignal 5defacb
Fix tests
ValentinVignal 2cf6259
Merge remote-tracking branch 'upstream/main' into tow-dimensional-scr…
ValentinVignal 8a912eb
Fix more memory leaks in tests
ValentinVignal 31fca6b
Merge remote-tracking branch 'upstream/main' into tow-dimensional-scr…
ValentinVignal f3b0982
Fix breaking changes
ValentinVignal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
packages/two_dimensional_scrollables/example/test/flutter_test_config.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // Copyright 2013 The Flutter Authors | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import 'dart:async'; | ||
|
|
||
| import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart'; | ||
|
|
||
| Future<void> testExecutable(FutureOr<void> Function() testMain) async { | ||
| LeakTesting.enable(); | ||
| LeakTracking.warnForUnsupportedPlatforms = false; | ||
| await testMain(); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm doing this to force the widget to rebuild (and re-run
_buildCell). Because now, when we toggle from "Single-cell" to "Disable" selection, the delegate doesn't change, and_buildCellis not rebuilt. That makes the testSelection SegmentedButton control worksinpackages/two_dimensional_scrollables/example/test/table_view/simple_table_test.dart:60fail.Ideally, I think we'd need some kind of notifier that the widget built in
_buildCellwould listen to. But since it is only an example, I'd thought this would be enough?What do you think?