[pigeon] Use hasLength and isEmpty in tests for better failure messages#11205
Open
srawlins wants to merge 1 commit intoflutter:mainfrom
Open
[pigeon] Use hasLength and isEmpty in tests for better failure messages#11205srawlins wants to merge 1 commit intoflutter:mainfrom
srawlins wants to merge 1 commit intoflutter:mainfrom
Conversation
Contributor
Author
|
This is test-excempt as it only affects tests, and I believe it is also version-bump-exempt for the same reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an expectation like
expect(foo.length, equals(0))fails, you just see a message like "7 is not 0." Changing these tests to useisEmptyandhasLength, likeexpect(foo, isEmpty), you'll instead see a much more useful message like "expected this thing to have 0 elements, but instead it was [a, b, c]."Pre-Review Checklist
[shared_preferences]///).