Skip to content

[pigeon] Use hasLength and isEmpty in tests for better failure messages#11205

Open
srawlins wants to merge 1 commit intoflutter:mainfrom
srawlins:hasLength
Open

[pigeon] Use hasLength and isEmpty in tests for better failure messages#11205
srawlins wants to merge 1 commit intoflutter:mainfrom
srawlins:hasLength

Conversation

@srawlins
Copy link
Contributor

@srawlins srawlins commented Mar 9, 2026

When an expectation like expect(foo.length, equals(0)) fails, you just see a message like "7 is not 0." Changing these tests to use isEmpty and hasLength, like expect(foo, isEmpty), you'll instead see a much more useful message like "expected this thing to have 0 elements, but instead it was [a, b, c]."

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates tests in packages/pigeon/test/pigeon_lib_test.dart to use dedicated collection matchers like isEmpty, hasLength, and containsAll. These changes improve the readability and failure output of the tests.

@srawlins
Copy link
Contributor Author

srawlins commented Mar 9, 2026

This is test-excempt as it only affects tests, and I believe it is also version-bump-exempt for the same reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant