[pigeon] Produce a helpful error for bad method return type#11204
Open
srawlins wants to merge 3 commits intoflutter:mainfrom
Open
[pigeon] Produce a helpful error for bad method return type#11204srawlins wants to merge 3 commits intoflutter:mainfrom
srawlins wants to merge 3 commits intoflutter:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request improves error handling in Pigeon by providing a more informative error message for methods with unexpected or missing return types, preventing null-pointer exceptions. The changes are accompanied by relevant tests. My review includes a suggestion to fix a typo in a variable name for better code clarity and maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we encounter an unexpected (or missing) method return type, we now produce a meaningful error instead of a null-pointer exception.
Fixes flutter/flutter#92639
Pre-Review Checklist
[shared_preferences]///).