[google_maps_flutter] Add missing exports#11196
[google_maps_flutter] Add missing exports#11196stuartmorgan-g wants to merge 1 commit intoflutter:mainfrom
Conversation
Like much of the `google_maps_flutter` APIs currently, advanced markers rely on clients using types that are defined in the platform interface package. This re-exports them, and fixes the examples to not import the platform interface. Ideally we would have more separation between the API layers, but this is deeply ingrained in the API design of the plugin at this point, so changing it would require a comprehensive overhaul.
There was a problem hiding this comment.
Code Review
This pull request correctly adds missing re-exports for advanced marker-related classes from the google_maps_flutter_platform_interface package into the main google_maps_flutter package. The example files have been updated to reflect these changes by removing direct imports from the platform interface, which improves the API's consistency and usability. The changelog and pubspec.yaml have also been updated appropriately. The changes are well-aligned with the pull request's objective.
|
@jokerttu I ran into one potentially thorn issue here that I completely missed in review: one of the example pages is calling Don't clients need to know whether advanced marker support is available before passing the advanced marker type to |
This adds exports that should have been in #7882, but I missed in review.
Like much of the
google_maps_flutterAPIs currently, advanced markers rely on clients using types that are defined in the platform interface package. This re-exports them, and fixes the examples to not import the platform interface.Ideally we would have more separation between the API layers, but this is deeply ingrained in the API design of the plugin at this point, so changing it would require a comprehensive overhaul.
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2