-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[animations] Clarify that onClosed is called before transition #10400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[animations] Clarify that onClosed is called before transition #10400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation for OpenContainer.onClosed to clarify that the callback is executed at the start of the closing transition, not at the end. The change correctly reflects the component's behavior. The version in pubspec.yaml and the CHANGELOG.md have been updated accordingly. I have one suggestion to make the documentation even more explicit.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
hannah-hyj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
justinmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
| /// Called when the container is popped. This is called at the start of the | ||
| /// closing transition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| /// Called when the container is popped. This is called at the start of the | |
| /// closing transition. | |
| /// Called when the container was popped and will return to the closed state. | |
| /// | |
| /// This is called at the start of the closing transition. |
Updated the documentation for
OpenContainer.onClosedto clarify that it is called at the start of the closing transition, not at the end.Resolves flutter/flutter#178314
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
This PR only affects comments/documentation. ↩