Skip to content

Clean up and combine dependabot updates - #2866

Open
parlough wants to merge 2 commits into
mainfrom
misc/dependabot-simplification
Open

parlough wants to merge 2 commits into
mainfrom
misc/dependabot-simplification

Conversation

@parlough

Copy link
Copy Markdown
Member
  • Consolidate pub ecosystem entries per codelab and group updates by dependency name.
  • Add seven-day cooldowns to appease zizmor checks.
  • Remove the stale pip entry and unused beta flag.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .github/dependabot.yaml configuration to consolidate dependency management across multiple codelab steps. However, the review identified several critical configuration errors: the cooldown option is invalid, the group-by key is not supported within the groups configuration, and the use of wildcard paths in directories is not supported by Dependabot, requiring explicit path definitions.

Comment thread .github/dependabot.yaml
Comment on lines 7 to +9
interval: "daily"
# Don't auto-submit github action updates until subosito/flutter-action update is cleared
cooldown:
default-days: 7

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The cooldown option is not a valid configuration key in GitHub Dependabot. Including it will cause Dependabot to fail parsing this configuration file entirely, preventing any updates from running.

If you want to reduce the frequency of updates, you can change the schedule.interval to weekly or monthly instead of daily. Please remove this block here and from all other ecosystem entries in this file.

      interval: "daily"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Gemini doesn't like this flag. Thoughts?

Comment thread .github/dependabot.yaml
Comment on lines 24 to +28
labels:
- "autosubmit"
groups:
animated-responsive-layout:
group-by: "dependency-name"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The group-by key is not a valid option under Dependabot's groups configuration. Using it will cause a schema validation error, and Dependabot will fail to run.

Depending on your intent, you have two options:

  1. If you want one PR per dependency across all directories (e.g., one PR updating provider across all steps): You can remove the groups block entirely. Dependabot automatically groups updates of the same dependency across directories specified in directories by default.
  2. If you want to group all dependency updates for a specific codelab into a single PR (e.g., one PR for all updates in animated-responsive-layout): Use patterns: ["*"] instead.
    labels:
      - "autosubmit"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Comment thread .github/dependabot.yaml
Comment on lines +168 to +170
directories:
- "/in_app_purchases/*/app"
- "/in_app_purchases/*/dart-backend"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Dependabot's wildcard support for directories is limited to trailing wildcards (e.g., /directory/*). It does not support wildcards in the middle of a path like /in_app_purchases/*/app or recursive globbing (**).

As a result, Dependabot will not be able to locate the pubspec.yaml files in these subdirectories. You should list these directories explicitly.

      - "/in_app_purchases/complete/app"
      - "/in_app_purchases/complete/dart-backend"
      - "/in_app_purchases/step_00/app"
      - "/in_app_purchases/step_00/dart-backend"
      - "/in_app_purchases/step_03/app"
      - "/in_app_purchases/step_03/dart-backend"
      - "/in_app_purchases/step_07/app"
      - "/in_app_purchases/step_07/dart-backend"
      - "/in_app_purchases/step_08/app"
      - "/in_app_purchases/step_08/dart-backend"
      - "/in_app_purchases/step_10/app"
      - "/in_app_purchases/step_10/dart-backend"
      - "/in_app_purchases/step_11/app"
      - "/in_app_purchases/step_11/dart-backend"

@domesticmouse domesticmouse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Gemini has thoughts. I don't have access to what the truth with dependabot's schema actually is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants