Skip to content

Add environment variable for plugin names to the mcp configuration - #238

Open
keertip wants to merge 1 commit into
flutter:mainfrom
keertip:env-var
Open

keertip wants to merge 1 commit into
flutter:mainfrom
keertip:env-var

Conversation

@keertip

@keertip keertip commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

This PR

  • moves the mcp configuration to the plugin.json file for the respective agents
  • adds an environment variable to indicate the agent plugin calling the mcp server
  • remove the unused .mcp.json file
  • bumps the version numbers for the plugins

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the plugin configuration files (.claude-plugin/plugin.json, .codex-plugin/plugin.json, and .cursor-plugin/plugin.json) to bump their versions to 1.0.5 and inline the mcpServers configuration with specific AGENT_PLUGIN environment variables (claude-code, codex, and cursor respectively), while removing the external .mcp.json file. The feedback suggests adding a trailing newline to the end of each of these JSON files to ensure POSIX compatibility and prevent git diff warnings.

Comment on lines +18 to +29
"mcpServers": {
"dart-mcp-server": {
"command": "dart",
"args": [
"mcp-server"
],
"env": {
"AGENT_PLUGIN": "claude-code"
}
}
}
} No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The JSON file is missing a trailing newline at the end of the file. Adding a trailing newline is a standard practice that ensures compatibility with POSIX tools and avoids unnecessary git diff warnings.

Suggested change
"mcpServers": {
"dart-mcp-server": {
"command": "dart",
"args": [
"mcp-server"
],
"env": {
"AGENT_PLUGIN": "claude-code"
}
}
}
}
"mcpServers": {
"dart-mcp-server": {
"command": "dart",
"args": [
"mcp-server"
],
"env": {
"AGENT_PLUGIN": "claude-code"
}
}
}
}

Comment thread .codex-plugin/plugin.json
Comment on lines 43 to +44
}
}
} No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The trailing newline at the end of the file was removed. It is recommended to keep a trailing newline to adhere to POSIX standards and prevent git diff warnings.

Suggested change
}
}
}
}
}

Comment on lines 29 to +30
"skills": "./skills/"
}
} No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The trailing newline at the end of the file was removed. It is recommended to keep a trailing newline to adhere to POSIX standards and prevent git diff warnings.

Suggested change
"skills": "./skills/"
}
}
"skills": "./skills/"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant