Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/video_player/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 2.5.15

* Update video_player to 2.14.0.
* Update video_player_platform_interface to 6.9.0.
* Updates minimum supported SDK version to Flutter 3.44/Dart 3.12.
Comment thread
JSUYA marked this conversation as resolved.

## 2.5.14

* Add an `implements` entry to the pubspec to improve discoverability on pub.dev.
Expand Down
4 changes: 2 additions & 2 deletions packages/video_player/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ This package is not an _endorsed_ implementation of `video_player`. Therefore, y

```yaml
dependencies:
video_player: ^2.11.1
video_player_tizen: ^2.5.14
video_player: ^2.14.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://pub.dev/packages/video_player/changelog#2140
For the new interfaces of video_player (e.g., getVideoTracks(), selectVideoTrack(), and isVideoTrackSupportAvailable()), you need to check for support in code or handle non-support in the README.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked the interfaces, the media player doesn't support these interfaces. and the README has included not-supported infomation:
https://github.com/flutter-tizen/plugins/pull/1095/changes#diff-1e0f851343e9d1c0959929911a85dbbc00f95cba7359a17d2ce12b38adc2bfa9L57-L62

The following methods are not currently supported.

- `VideoPlayerPlatform.setAllowBackgroundPlayback()`
- `VideoPlayerPlatform.getAudioTracks()`
- `VideoPlayerPlatform.selectAudioTrack()`
- `VideoPlayerPlatform.isAudioTrackSupportAvailable()`

This plugin has the following limitations.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check and add new APIs to the list of unsupported interfaces.

video_player_tizen: ^2.5.15
```

Then you can import `video_player` in your Dart code:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ import 'package:video_player/video_player.dart';
const Duration _playDuration = Duration(seconds: 1);

// Use WebM for web to allow CI to use Chromium.
const String _videoAssetKey =
kIsWeb ? 'assets/Butterfly-209.webm' : 'assets/Butterfly-209.mp4';
const String _videoAssetKey = kIsWeb
? 'assets/Butterfly-209.webm'
: 'assets/Butterfly-209.mp4';

// Returns the URL to load an asset from this example app as a network source.
//
Expand Down Expand Up @@ -217,19 +218,17 @@ void main() {
child: Center(
child: FutureBuilder<bool>(
future: started(),
builder: (
BuildContext context,
AsyncSnapshot<bool> snapshot,
) {
if (snapshot.data ?? false) {
return AspectRatio(
aspectRatio: controller.value.aspectRatio,
child: VideoPlayer(controller),
);
} else {
return const Text('waiting for video to load');
}
},
builder:
(BuildContext context, AsyncSnapshot<bool> snapshot) {
if (snapshot.data ?? false) {
return AspectRatio(
aspectRatio: controller.value.aspectRatio,
child: VideoPlayer(controller),
);
} else {
return const Text('waiting for video to load');
}
},
),
),
),
Expand Down
23 changes: 11 additions & 12 deletions packages/video_player/example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -304,20 +304,19 @@ class _ControlsOverlay extends StatelessWidget {
AnimatedSwitcher(
duration: const Duration(milliseconds: 50),
reverseDuration: const Duration(milliseconds: 200),
child:
controller.value.isPlaying
? const SizedBox.shrink()
: const ColoredBox(
color: Colors.black26,
child: Center(
child: Icon(
Icons.play_arrow,
color: Colors.white,
size: 100.0,
semanticLabel: 'Play',
),
child: controller.value.isPlaying
? const SizedBox.shrink()
: const ColoredBox(
color: Colors.black26,
child: Center(
child: Icon(
Icons.play_arrow,
color: Colors.white,
size: 100.0,
semanticLabel: 'Play',
),
),
),
),
GestureDetector(
onTap: () {
Expand Down
6 changes: 3 additions & 3 deletions packages/video_player/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ description: Demonstrates how to use the video_player_tizen plugin.
publish_to: "none"

environment:
sdk: ^3.7.0
flutter: ">=3.29.0"
sdk: ^3.12.0
flutter: ">=3.44.0"

dependencies:
flutter:
sdk: flutter
video_player: ^2.11.1
video_player: ^2.14.0
video_player_tizen:
path: ../

Expand Down
9 changes: 5 additions & 4 deletions packages/video_player/lib/src/messages.g.dart
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,8 @@ class CreateMessage {
uri: result[1] as String?,
packageName: result[2] as String?,
formatHint: result[3] as String?,
httpHeaders:
(result[4] as Map<Object?, Object?>?)!.cast<String?, String?>(),
httpHeaders: (result[4] as Map<Object?, Object?>?)!
.cast<String?, String?>(),
);
}

Expand Down Expand Up @@ -383,8 +383,9 @@ class TizenVideoPlayerApi {
BinaryMessenger? binaryMessenger,
String messageChannelSuffix = '',
}) : pigeonVar_binaryMessenger = binaryMessenger,
pigeonVar_messageChannelSuffix =
messageChannelSuffix.isNotEmpty ? '.$messageChannelSuffix' : '';
pigeonVar_messageChannelSuffix = messageChannelSuffix.isNotEmpty
? '.$messageChannelSuffix'
: '';
final BinaryMessenger? pigeonVar_binaryMessenger;

static const MessageCodec<Object?> pigeonChannelCodec = _PigeonCodec();
Expand Down
7 changes: 3 additions & 4 deletions packages/video_player/lib/video_player_tizen.dart
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,9 @@ class VideoPlayerTizen extends platform_interface.VideoPlayerPlatform {
final List<dynamic> values = map['values'] as List<dynamic>;

return platform_interface.VideoEvent(
buffered:
values
.map<platform_interface.DurationRange>(_toDurationRange)
.toList(),
buffered: values
.map<platform_interface.DurationRange>(_toDurationRange)
.toList(),
eventType: platform_interface.VideoEventType.bufferingUpdate,
);
case 'bufferingStart':
Expand Down
8 changes: 4 additions & 4 deletions packages/video_player/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ name: video_player_tizen
description: Tizen implementation of the video_player plugin.
homepage: https://github.com/flutter-tizen/plugins
repository: https://github.com/flutter-tizen/plugins/tree/main/packages/video_player
version: 2.5.14
version: 2.5.15

environment:
sdk: ^3.7.0
flutter: ">=3.29.0"
sdk: ^3.12.0
flutter: ">=3.44.0"

flutter:
plugin:
Expand All @@ -20,7 +20,7 @@ flutter:
dependencies:
flutter:
sdk: flutter
video_player_platform_interface: ^6.6.0
video_player_platform_interface: ^6.9.0

dev_dependencies:
pigeon: ^25.5.0
Loading