-
Notifications
You must be signed in to change notification settings - Fork 54
[flutter_inappwebview] Fix navigation/getUrl/scroll bugs and add integration tests #1083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
seungsoo47
wants to merge
8
commits into
flutter-tizen:master
from
seungsoo47:flutter_inappwebview-nav-getUrl-fix
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
508da72
[flutter_inappwebview] Fix onTitleChanged to fire after the initial p…
seungsoo47 cd951fb
[flutter_inappwebview] Fix getUrl race and shouldOverrideUrlLoading r…
seungsoo47 2338d9b
[flutter_inappwebview] Fix scrollBy/getScrollX/getScrollY returning s…
seungsoo47 b615832
[flutter_inappwebview] Bump flutter_inappwebview_tizen to 0.2.0
seungsoo47 6bb2e06
[flutter_inappwebview] Add integration tests based on upstream v6.1.5
seungsoo47 ad7dd6b
[flutter_inappwebview] Fix format
seungsoo47 e7dcbb1
[flutter_inappwebview] Fix stale programmatic-nav flag and scroll target
seungsoo47 d1b459a
[flutter_inappwebview] Let remote Back reach the delegate; fix stale …
seungsoo47 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
packages/flutter_inappwebview/example/assets/test_assets/load_file_test.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <!doctype html> | ||
| <html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>Load file test</title> | ||
| </head> | ||
| <body> | ||
| <h1>Loaded from asset</h1> | ||
| </body> | ||
| </html> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most md files do not use this type of line break. Also, the modifications must be explained briefly. Detailed explanations should be provided in the body of the PR.