fix(juicefs): read metaurl from SharedEncryptOptions when deciding the edition

[cheyang]

What this PR does

genEdition takes the dataset-wide encrypt options as its third parameter, but transform passes the mount's own options:

// pkg/ddc/juicefs/transform.go
j.genEdition(dataset.Spec.Mounts[0], value, dataset.Spec.Mounts[0].EncryptOptions)

Mounts[0].EncryptOptions is therefore scanned twice and Dataset.Spec.SharedEncryptOptions is never looked at. A Dataset that declares metaurl only in SharedEncryptOptions is classified as the enterprise edition.

genValue does read SharedEncryptOptions, so such a Dataset ends up with Source = "${METAURL}" while Edition = enterprise. Two things follow from that mismatch:

1. The file system is never formatted. genFormatCmd takes the enterprise branch, where an empty TokenSecret returns early:

// ee
if value.Configs.TokenSecret == "" {
    // skip juicefs auth
    return
}

so Configs.FormatCmd stays empty. parseJuiceFSImage also selects the enterprise image for what is a community deployment.

2. Teardown fails and keeps retrying. getUUID returns early for the enterprise edition with uuid = Source, so the literal string ${METAURL} is joined into the cache path. cleanupCache then asks to delete <cacheDir>/${METAURL}/raw/chunks, which cmdguard rejects for containing $, so Shutdown returns an error and increments retryShutdown.

The change

Pass dataset.Spec.SharedEncryptOptions, which is what the parameter is named after:

-j.genEdition(dataset.Spec.Mounts[0], value, dataset.Spec.Mounts[0].EncryptOptions)
+j.genEdition(dataset.Spec.Mounts[0], value, dataset.Spec.SharedEncryptOptions)

genEdition itself is unchanged — it already scans both lists correctly.

Compatibility

This changes how a Dataset with metaurl only in SharedEncryptOptions is classified, so I checked whether anyone could be relying on the current behaviour. They cannot: as described above such a deployment gets the enterprise image, an empty FormatCmd, and a teardown that always fails. It never worked, so the change is a fix rather than a break. Datasets that declare metaurl on the mount are unaffected.

Testing

The existing genEdition specs call the function directly with hand-built arguments, so they cover its logic but not how transform invokes it — which is exactly where the defect was. Added a table that goes through transform and asserts the edition for metaurl declared on the mount, in SharedEncryptOptions, in both, and in neither.

To confirm the new coverage actually pins the call site, I reverted the one-line change and re-ran: only the metaurl in SharedEncryptOptions case fails (173 passed / 1 failed), the other three still pass.

Verified on Linux with the CI command (go list ./... | grep -v controller | grep -v e2etest | xargs go test -gcflags="all=-N -l"), comparing the run with and without the fix:

failing packages only WITH fix (regressions)   -> none
failing tests only WITH fix (regressions)      -> none
common failures (pre-existing both sides)      -> TestWebhook

pkg/ddc/juicefs is green at 174/174 specs; go build ./... and go vet are clean. The single pre-existing TestWebhook failure reproduces identically without this change.

[gemini-code-assist]

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.15%. Comparing base (7c00ed2) to head (c763734).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6148      +/-   ##
==========================================
+ Coverage   65.13%   65.15%   +0.02%     
==========================================
  Files         485      485              
  Lines       34039    34039              
==========================================
+ Hits        22171    22179       +8     
+ Misses      10127    10121       -6     
+ Partials     1741     1739       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Fixes JuiceFS edition detection by ensuring transform passes dataset-wide SharedEncryptOptions into genEdition, so metaurl declared at the dataset level correctly selects the community edition (preventing downstream formatting/teardown issues caused by an enterprise/community mismatch).

Changes:

• Update transform to pass dataset.Spec.SharedEncryptOptions to genEdition (instead of the mount’s EncryptOptions).
• Add table-driven coverage that exercises transform end-to-end for metaurl placement (mount vs shared vs both vs neither).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
pkg/ddc/juicefs/transform.go	Fixes the genEdition call site to use SharedEncryptOptions, aligning edition detection with genValue behavior.
pkg/ddc/juicefs/transform_test.go	Adds integration-style table cases through transform to prevent regressions at the call site.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.