Skip to content

test(jindo): add missing unit tests for JindoEngine SyncRuntime#5996

Open
Sukuna0007Abhi wants to merge 2 commits into
fluid-cloudnative:masterfrom
Sukuna0007Abhi:fix-jindo-sync-test
Open

test(jindo): add missing unit tests for JindoEngine SyncRuntime#5996
Sukuna0007Abhi wants to merge 2 commits into
fluid-cloudnative:masterfrom
Sukuna0007Abhi:fix-jindo-sync-test

Conversation

@Sukuna0007Abhi

Copy link
Copy Markdown
Contributor

Ⅰ. Describe what this PR does

This PR adds missing unit tests for the SyncRuntime method in the JindoEngine. It uses table-driven testing to cover the default logic of SyncRuntime, which currently logs the sync and returns true, nil. This improves the overall code coverage for the Jindo runtime package.

Ⅱ. Does this pull request fix one or more issues?

fixes #5995

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

  • TestJindoEngine_SyncRuntime added to pkg/ddc/jindo/sync_runtime_test.go

Ⅳ. Describe how to verify it

make unit-test

Signed-off-by: Sukuna0007Abhi <appsonly310@gmail.com>
@fluid-e2e-bot

fluid-e2e-bot Bot commented Jun 14, 2026

Copy link
Copy Markdown

Hi @Sukuna0007Abhi. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors TestJindoEngine_SyncRuntime in pkg/ddc/jindo/sync_runtime_test.go by removing unused commented-out fields and arguments to simplify the test setup. Feedback suggests initializing the embedded Context field in cruntime.ReconcileRequestContext with context.TODO() to prevent potential nil pointer dereference panics during test execution.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pkg/ddc/jindo/sync_runtime_test.go Outdated
…inter dereference

Signed-off-by: Sukuna0007Abhi <appsonly310@gmail.com>
@sonarqubecloud

Copy link
Copy Markdown

@Sukuna0007Abhi

Copy link
Copy Markdown
Contributor Author

Plz review @cheyang @TrafalgarZZZ

@fluid-e2e-bot

fluid-e2e-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sukuna0007Abhi

Copy link
Copy Markdown
Contributor Author

Thanks @cheyang

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.56%. Comparing base (ae86e7c) to head (1c45b93).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5996   +/-   ##
=======================================
  Coverage   63.56%   63.56%           
=======================================
  Files         479      479           
  Lines       33276    33276           
=======================================
  Hits        21151    21151           
  Misses      10445    10445           
  Partials     1680     1680           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cheyang

cheyang commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

@Sukuna0007Abhi Please run make fmt to fix lint check issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURES] Add missing unit tests for JindoEngine SyncRuntime

2 participants