Migrate (pkg/ddc/thin/worker_test.go) tests to use Ginkgo #5539

hxrshxz · 2026-01-28T03:42:45Z

Ⅰ. Describe what this PR does

Migrate unit tests in pkg/ddc/thin/worker_test.go to use Ginkgo/Gomega.

Ⅱ. Does this pull request fix one issue?

part of #5407

Ⅲ. List the added test cases

No new test cases. Migrated existing tests to Ginkgo/Gomega.

Ⅳ. Describe how to verify it

go test -v ./pkg/ddc/thin/... -count=1

Ⅴ. Special notes for reviews

N/A

Signed-off-by: Harsh <harshmastic@gmail.com>

gemini-code-assist · 2026-01-28T03:42:48Z

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

hxrshxz · 2026-01-28T03:42:55Z

/gemini review

hxrshxz · 2026-01-28T03:42:57Z

/gemini review

gemini-code-assist · 2026-01-28T03:42:58Z

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

gemini-code-assist · 2026-01-28T03:43:00Z

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

fluid-e2e-bot · 2026-01-28T03:43:02Z

Hi @hxrshxz. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copilot

Pull request overview

Migrates pkg/ddc/thin/worker_test.go unit tests from Go’s testing package style to Ginkgo/Gomega.

Changes:

Replaced table-driven testing.T tests with Ginkgo Describe/It specs for worker-related behaviors.
Updated assertions to Gomega Expect style.
Adjusted imports/scheme setup to support the new test style.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-28T03:47:03Z

pkg/ddc/thin/worker_test.go

+var _ = Describe("ThinEngine_ShouldSetupWorkers", func() {
+	It("should return true when worker phase is None and worker is enabled", func() {
+		runtime := &datav1alpha1.ThinRuntime{


These are Ginkgo specs in package thin, but the only suite runner in this directory is pkg/ddc/thin/thin_suite_test.go which is declared as package thin_test. With go test, specs in package thin won't be executed unless there is a RunSpecs test in the same package. Please add/update a suite file in package thin (or move these specs to package thin_test and adjust access) so these tests actually run.

Copilot · 2026-01-28T03:47:03Z

pkg/ddc/thin/worker_test.go

+				Namespace: "fluid",
+			},
+			Spec: datav1alpha1.ThinRuntimeSpec{
+				Replicas: 1,


SetupWorkers() short-circuits when t.runtime.Spec.Worker.Enabled is false (ThinEngine.isWorkerEnable()). In this test, runtime.Spec.Worker.Enabled is never set, so the test currently exercises the no-op path and doesn't validate worker setup behavior. Set runtime.Spec.Worker.Enabled = true (and any other required runtime fields) so the test actually covers SetupWorkers logic.

Suggested change

Replicas: 1,

Replicas: 1,

Worker: datav1alpha1.ThinCompTemplateSpec{

Enabled: true,

},

Copilot · 2026-01-28T03:47:04Z

pkg/ddc/thin/worker_test.go

+		err = e.SetupWorkers()
+		Expect(err).NotTo(HaveOccurred())
+		Expect(*worker.Spec.Replicas).To(Equal(int32(1)))
+	})


The assertion Expect(*worker.Spec.Replicas)... checks the local worker variable, but SetupWorkers() will update the StatefulSet stored in the fake client, not this local value (you passed worker.DeepCopy() into the client). This makes the test pass even if scaling never happens. Fetch the StatefulSet back from mockClient after SetupWorkers() and assert on the retrieved object's fields; similarly, re-add any removed assertions (e.g., node label updates) that the previous table-driven test covered.

codecov · 2026-01-28T03:49:30Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.29%. Comparing base (a011407) to head (161897a).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5539   +/-   ##
=======================================
  Coverage   61.29%   61.29%           
=======================================
  Files         444      444           
  Lines       30540    30540           
=======================================
  Hits        18718    18718           
  Misses      10280    10280           
  Partials     1542     1542

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Harsh <harshmastic@gmail.com>

Restores pkg/ddc/base/base_suite_test.go and runtime_conventions_test.go to their upstream versions. These files should remain as package base_test (external test package) to avoid conflicts with existing tests. Signed-off-by: Harsh <harshmastic@gmail.com>

pkg/ddc/thin/worker_test.go

cheyang

Please fix the conflict issue.

hxrshxz · 2026-02-10T07:20:30Z

putting in draft will fix soon

fluid-e2e-bot · 2026-02-10T14:06:56Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cheyang for approval by writing /assign @cheyang in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sonarqubecloud · 2026-02-10T14:07:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
71.9% Duplication on New Code

See analysis details on SonarQube Cloud

test(thin): migrate worker tests to ginkgo

b12edf8

Signed-off-by: Harsh <harshmastic@gmail.com>

Copilot AI review requested due to automatic review settings January 28, 2026 03:42

fluid-e2e-bot bot added the needs-ok-to-test label Jan 28, 2026

Copilot started reviewing on behalf of hxrshxz January 28, 2026 03:43 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

hxrshxz added 3 commits January 28, 2026 16:48

fix: enable worker + fetch from client + suite package + import alias

36664d5

Signed-off-by: Harsh <harshmastic@gmail.com>

fix: change base suite and tests to package base

1db9912

Signed-off-by: Harsh <harshmastic@gmail.com>

cheyang reviewed Feb 10, 2026

View reviewed changes

pkg/ddc/thin/worker_test.go Show resolved Hide resolved

cheyang requested changes Feb 10, 2026

View reviewed changes

hxrshxz requested a review from cheyang February 10, 2026 07:18

hxrshxz marked this pull request as draft February 10, 2026 07:18

fluid-e2e-bot bot added the do-not-merge/work-in-progress label Feb 10, 2026

hxrshxz force-pushed the ginkgo/thin-worker branch from 161897a to 5c26c46 Compare February 10, 2026 14:06

Migrate (pkg/ddc/thin/worker_test.go) tests to use Ginkgo #5539

Are you sure you want to change the base?

Migrate (pkg/ddc/thin/worker_test.go) tests to use Ginkgo #5539

Uh oh!

Conversation

hxrshxz commented Jan 28, 2026

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Uh oh!

gemini-code-assist bot commented Jan 28, 2026

Uh oh!

hxrshxz commented Jan 28, 2026

Uh oh!

hxrshxz commented Jan 28, 2026

Uh oh!

gemini-code-assist bot commented Jan 28, 2026

Uh oh!

gemini-code-assist bot commented Jan 28, 2026

Uh oh!

fluid-e2e-bot bot commented Jan 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

cheyang left a comment

Choose a reason for hiding this comment

Uh oh!

hxrshxz commented Feb 10, 2026

Uh oh!

fluid-e2e-bot bot commented Feb 10, 2026

Uh oh!

sonarqubecloud bot commented Feb 10, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Jan 28, 2026 •

edited

Loading