Skip to content

tests: runtime: Adopt the test config path for Windows and others - #12227

Merged
edsiper merged 1 commit into
masterfrom
cosmo0920-fix-failing-test-cases-on-windows
Aug 5, 2026
Merged

tests: runtime: Adopt the test config path for Windows and others#12227
edsiper merged 1 commit into
masterfrom
cosmo0920-fix-failing-test-cases-on-windows

Conversation

@cosmo0920

@cosmo0920 cosmo0920 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Without this patch, one of the runtime test cases is failing:

flb-rt-in_calyptia_fleet_test ....................***Failed    0.08 sec
Test in_calyptia_fleet_format...                [ OK ]
Test in_calyptia_fleet_timestamped_config_format... [ FAILED ]
  in_calyptia_fleet_test.c:146: Check value && strcmp(value, expectedValue) == 0... failed
  in_calyptia_fleet_test.c:159: Check value && strcmp(value, expectedValue) == 0... failed
FAILED: 1 of 2 unit tests has failed.

Fixed the Windows path expectations in in_calyptia_fleet_test.c. Both cases now use TEST_FLEET_CONFIG_DIR and PATH_SEPARATOR.

Verification:

  • Focused target rebuilt successfully.
  • Exact timestamped test: passed, all assertions.
  • ctest --test-dir build -R "^flb-rt-in_calyptia_fleet_test$" --output-on-failure: passed, 1/1.
  • Valgrind was not run because it is unavailable on Windows; no corresponding Python integration scenario exists.

Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

  • Bug Fixes
    • Improved fleet configuration path handling across platforms.
    • Updated validation for timestamped legacy .conf and YAML configuration files.

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0d77d6d6-7056-4bd0-b07a-441ae7d75346

📥 Commits

Reviewing files that changed from the base of the PR and between cf50b7e and 75fac0f.

📒 Files selected for processing (1)
  • tests/runtime/in_calyptia_fleet_test.c

📝 Walkthrough

Walkthrough

The runtime fleet tests now build expected legacy and YAML timestamped configuration paths with TEST_FLEET_CONFIG_DIR and the platform-specific PATH_SEPARATOR.

Changes

Fleet configuration test paths

Layer / File(s) Summary
Update timestamped path expectations
tests/runtime/in_calyptia_fleet_test.c
The legacy and YAML path expectations now use TEST_FLEET_CONFIG_DIR and PATH_SEPARATOR instead of hardcoded path components.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • fluent/fluent-bit#11962: Introduced and exercised the timestamped fleet configuration filename changes covered by these tests.

Suggested reviewers: edsiper

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the runtime test configuration path changes for Windows and other platforms.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cosmo0920-fix-failing-test-cases-on-windows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@edsiper
edsiper merged commit 4e11543 into master Aug 5, 2026
89 of 91 checks passed
@edsiper
edsiper deleted the cosmo0920-fix-failing-test-cases-on-windows branch August 5, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants